Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 742a9580b8b72cb5fa1523f9d6b9adc90ed6b3b9
https://github.com/WebKit/WebKit/commit/742a9580b8b72cb5fa1523f9d6b9adc90ed6b3b9
Author: Alan Baradlay <za...@apple.com>
Date: 2025-09-19 (Fri, 19 Sep 2025)
Changed paths:
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/rendering/TextBoxPainter.h
Log Message:
-----------
[text shaping] Selection paint rect should follow shaped content
https://bugs.webkit.org/show_bug.cgi?id=299129
Reviewed by Antti Koivisto.
This patch ensures that selection follows the shaped (painted) content.
1. Make a dedicated function to build text for shaping across display boxes
(paint and text selection call this function)
2. Move selection adjustment logic to a function (selectionRectForRange)
where in case of shaping, we would call 'buildTextForShaping' and
adjust the selection rect accordingly.
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::buildTextForShaping):
(WebCore::TextBoxPainter::selectionRectForRange const):
(WebCore::TextBoxPainter::paintBackgroundFillForRange):
(WebCore::TextBoxPainter::paintForeground):
(WebCore::TextBoxPainter::paintForegroundForShapeRange):
(WebCore::TextBoxPainter::isInsideShapedContent const):
(WebCore::TextBoxPainter::paintForegroundForShapingRange): Deleted.
* Source/WebCore/rendering/TextBoxPainter.h:
Canonical link: https://commits.webkit.org/300241@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
