Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5daaee2a8856651b580bae81a352fbf9e3f2be0f
      
https://github.com/WebKit/WebKit/commit/5daaee2a8856651b580bae81a352fbf9e3f2be0f
  Author: Alan Baradlay <[email protected]>
  Date:   2025-09-27 (Sat, 27 Sep 2025)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  [text shaping] css/css-text/boundary-shaping/boundary-shaping-009.html fails 
when decoration is only on one of the (inline) sides
https://bugs.webkit.org/show_bug.cgi?id=299631

Reviewed by Antti Koivisto.

1. shaping happens before line breaking
2. visual reordering happens after line breaking

We try to figure out if inline box decoration introduces shaping boundary on
each sides of the inline box  (e.g. border between content).
However checking start/end here does not work as after line breaking
content may move around and can get to the "other" side of the inline box
that we checked _before_ line breaking.
For now let's just not do shaping if there's decoration regardless of the side.

* LayoutTests/TestExpectations: boundary-shaping-009.html never worked, 
test.html and -expected.html both fail the same way on trunk (so we "PASS").

* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::collectShapeRanges const):

Canonical link: https://commits.webkit.org/300635@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to