Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b5aed713d34f3b97363d919d03883e2812dae21e
https://github.com/WebKit/WebKit/commit/b5aed713d34f3b97363d919d03883e2812dae21e
Author: Sammy Gill <[email protected]>
Date: 2025-09-29 (Mon, 29 Sep 2025)
Changed paths:
M Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/grid/PlacedGridItem.cpp
M Source/WebCore/layout/formattingContexts/grid/PlacedGridItem.h
M Source/WebCore/layout/formattingContexts/grid/UnplacedGridItem.h
Log Message:
-----------
[GFC] Start storing some computed size properties on PlacedGridItem
https://bugs.webkit.org/show_bug.cgi?id=299812
rdar://161584151
Reviewed by Alan Baradlay.
We will need access to various bits of a grid item's computed style
during layout. For example, the preferred sizes are properties that can
significantly impact the sizing of a grid item and influence the rest of the
grid layout. One option is to put the pieces of information that we need
on PlacedGridItem so that they can be accessed during layout, which is
what this patch aims to do.
We do this as we construct the PlacedGridItem from its unplaced counterpart
inside of GridFormattingContext. We need to do this here since
GridFormattingContext will have enough information to map the various
properties to the inline and block dimensions as appropriate. Here we
just assume horizontal-tb with non-orthogonal content for
simplicity.
In this patch I add the preferred sizes, min/max sizes, along with
margins as part of ComputedSizes. I leave out border and padding for now
since those are just additional sizes which get resolved to their used
value as part of updating the formatting context geometries before
layout. If we need access to those values we may want to consider
accessing them in a slightly different way since they are slightly
different from these ComputedSizes.
Canonical link: https://commits.webkit.org/300734@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
