Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d7f2e52c03a8d52f3421e876b5157280f5369c7b
https://github.com/WebKit/WebKit/commit/d7f2e52c03a8d52f3421e876b5157280f5369c7b
Author: Elika Etemad <[email protected]>
Date: 2025-10-02 (Thu, 02 Oct 2025)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-001-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002.html
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp
M Source/WebCore/rendering/PositionedLayoutConstraints.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebCore/rendering/style/StyleSelfAlignmentData.cpp
M Source/WebCore/rendering/style/StyleSelfAlignmentData.h
M Source/WebCore/style/StyleBuilderConverter.h
Log Message:
-----------
Add align-self/justify-self dialog behavior to enable UA style for popovers
https://bugs.webkit.org/show_bug.cgi?id=299995
rdar://161779751
Reviewed by Tim Nguyen.
Adds new 'dialog' value to the self alignment position values, maps it to
be equivalent to 'center' in most cases, and gives it special behavior
for 'position-area' values other than 'none'. See
https://github.com/w3c/csswg-drafts/issues/10258
https://drafts.csswg.org/css-anchor-position-1/#conditional-centering
Tests:
imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-001.html
imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002-ref.html
imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-001-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-001.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/align-dialog-002.html:
Added.
Import WPT tests.
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Align.cpp:
(WebCore::CSSPropertyParserHelpers::isSelfPositionKeyword):
Implement parsing for 'dialog'.
* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
(WebCore::PositionedLayoutConstraints::resolveAlignmentValue const):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentOffset):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::columnAxisPositionForGridItem const):
(WebCore::RenderGrid::rowAxisPositionForGridItem const):
Update layout code to handle ItemPosition::Dialog.
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleSelfAlignmentData.cpp:
(WebCore::StyleSelfAlignmentData::adjustmentFromStartEdge):
* Source/WebCore/rendering/style/StyleSelfAlignmentData.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::oppositeItemPosition):
Update style system to handle ItemPosition::Dialog.
Canonical link: https://commits.webkit.org/300865@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
