Title: [113388] trunk/Source/WebKit2
- Revision
- 113388
- Author
- [email protected]
- Date
- 2012-04-05 15:42:30 -0700 (Thu, 05 Apr 2012)
Log Message
[mac] requestAnimationFrame sometimes stuck when page loads in a background tab
https://bugs.webkit.org/show_bug.cgi?id=76105
Unreviewed build fix for Windows. windowIsVisible() is PLATFORM(MAC) only.
This means a Page might start requestAnimationFrame-based animations
even when it isn't visible. This should only happen when a Page is
opened in the background though. The regular hide and show should still
pause animations.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::resumePainting):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (113387 => 113388)
--- trunk/Source/WebKit2/ChangeLog 2012-04-05 22:33:19 UTC (rev 113387)
+++ trunk/Source/WebKit2/ChangeLog 2012-04-05 22:42:30 UTC (rev 113388)
@@ -3,6 +3,20 @@
[mac] requestAnimationFrame sometimes stuck when page loads in a background tab
https://bugs.webkit.org/show_bug.cgi?id=76105
+ Unreviewed build fix for Windows. windowIsVisible() is PLATFORM(MAC) only.
+ This means a Page might start requestAnimationFrame-based animations
+ even when it isn't visible. This should only happen when a Page is
+ opened in the background though. The regular hide and show should still
+ pause animations.
+
+ * WebProcess/WebPage/DrawingAreaImpl.cpp:
+ (WebKit::DrawingAreaImpl::resumePainting):
+
+2012-04-05 Dean Jackson <[email protected]>
+
+ [mac] requestAnimationFrame sometimes stuck when page loads in a background tab
+ https://bugs.webkit.org/show_bug.cgi?id=76105
+
Reviewed by Simon Fraser.
When we are resuming painting only start the scripted animations
Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp (113387 => 113388)
--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2012-04-05 22:33:19 UTC (rev 113387)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2012-04-05 22:42:30 UTC (rev 113388)
@@ -436,8 +436,12 @@
// FIXME: We shouldn't always repaint everything here.
setNeedsDisplay(m_webPage->bounds());
+#if PLATFORM(MAC)
if (m_webPage->windowIsVisible())
m_webPage->corePage()->resumeScriptedAnimations();
+#else
+ m_webPage->corePage()->resumeScriptedAnimations();
+#endif
}
void DrawingAreaImpl::enterAcceleratedCompositingMode(GraphicsLayer* graphicsLayer)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
