Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 679366a61a1d9d96ba355d5252de6df0c2280bf4
      
https://github.com/WebKit/WebKit/commit/679366a61a1d9d96ba355d5252de6df0c2280bf4
  Author: Yulun Wu <[email protected]>
  Date:   2025-10-02 (Thu, 02 Oct 2025)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/grid/GridLayout.cpp
    M Source/WebCore/layout/formattingContexts/grid/GridLayout.h
    M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.cpp
    M Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.h
    M Source/WebCore/layout/formattingContexts/grid/UnplacedGridItem.cpp
    M Source/WebCore/layout/formattingContexts/grid/UnplacedGridItem.h

  Log Message:
  -----------
  [GFC] Definite position checking and span sizing.
https://bugs.webkit.org/show_bug.cgi?id=299390
<rdar://161194270>

Reviewed by Sammy Gill.

This change introduces the following changes in preperation for
placing items with a definite row position in step 2 of:

  https://www.w3.org/TR/css-grid-1/#auto-placement-algo

1. hasDefiniteRowPosition to determine eligability for placement in step 2
of the grid auto placement algorithm.

2. an initial stub implementation of insertDefiniteRowItem with dense/sparse
styling information.

3.UnplacedGridItem::columnSpanSize() to compute the column size of an
UnplacedGridItem without explicit column start and end.

4. UnplacedGridItem::definiteRowStartEnd() to compute the start/end for
UnplacedGridItem without explicit row start and end.

Combined changes:
* Source/WebCore/layout/formattingContexts/grid/GridFormattingContext.cpp:
(WebCore::Layout::GridFormattingContext::constructUnplacedGridItems const):
* Source/WebCore/layout/formattingContexts/grid/GridLayout.cpp:
(WebCore::Layout::GridLayout::placeGridItems):
* Source/WebCore/layout/formattingContexts/grid/GridLayout.h:
* Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.cpp:
(WebCore::Layout::ImplicitGrid::insertDefiniteRowItem):
* Source/WebCore/layout/formattingContexts/grid/ImplicitGrid.h:
* Source/WebCore/layout/formattingContexts/grid/UnplacedGridItem.cpp:
(WebCore::Layout::UnplacedGridItem::hasDefinitePosition const):
(WebCore::Layout::UnplacedGridItem::hasDefiniteRowPosition const):
(WebCore::Layout::UnplacedGridItem::hasAutoColumnPosition const):
(WebCore::Layout::UnplacedGridItem::columnSpanSize const):
(WebCore::Layout::UnplacedGridItem::hasDefiniteColumnPosition const):
* Source/WebCore/layout/formattingContexts/grid/UnplacedGridItem.h:

Canonical link: https://commits.webkit.org/300893@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to