Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bc47e75992068516a93f529867db051f59073526
https://github.com/WebKit/WebKit/commit/bc47e75992068516a93f529867db051f59073526
Author: Yoel Hawa <[email protected]>
Date: 2025-10-03 (Fri, 03 Oct 2025)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/images/spatial-image-controls-expected.html
A LayoutTests/fast/images/spatial-image-controls-rtl-expected.html
A LayoutTests/fast/images/spatial-image-controls-rtl.html
M LayoutTests/platform/visionos/TestExpectations
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/html/shadow/SpatialImageControls.cpp
M Source/WebCore/html/shadow/spatialImageControls.css
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
Log Message:
-----------
Add RTL language and localization support to image controls
https://bugs.webkit.org/show_bug.cgi?id=299915
<rdar://161690817>
Reviewed by Abrar Rahman Protyasha.
Use localized string for image controls label. Also detect system RTL
language usage and adjust layout as appropriate.
* Source/WebCore/html/shadow/SpatialImageControls.cpp:
(WebCore::SpatialImageControls::ensureSpatialControls):
* Source/WebCore/html/shadow/spatialImageControls.css:
(div#label):
(span#spatial-glyph):
(span#pano-glyph):
Mirror layout iff system is in RTL language.
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::imageControlsLabelSpatial):
(WebCore::imageControlsLabelPanorama):
* Source/WebCore/platform/LocalizedStrings.h:
Make label text localizable strings.
* LayoutTests/TestExpectations:
* LayoutTests/fast/images/spatial-image-controls-expected.html:
* LayoutTests/fast/images/spatial-image-controls-rtl-expected.html:
* LayoutTests/fast/images/spatial-image-controls-rtl.html:
* LayoutTests/platform/visionos/TestExpectations:
Add test coverage for RTL support.
Canonical link: https://commits.webkit.org/300966@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
