Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 687f8f0e2b6b52578f3ebb78d1d0e0d63555c749
https://github.com/WebKit/WebKit/commit/687f8f0e2b6b52578f3ebb78d1d0e0d63555c749
Author: Nipun Shukla <[email protected]>
Date: 2025-10-08 (Wed, 08 Oct 2025)
Changed paths:
A LayoutTests/fast/css/contain-intrinsic-size-does-not-leak-expected.txt
A LayoutTests/fast/css/contain-intrinsic-size-does-not-leak.html
A LayoutTests/fast/css/resources/contain-intrinsic-size-leak-test.html
M Source/WebCore/bindings/js/JSResizeObserverCustom.cpp
M Source/WebCore/page/ResizeObserver.cpp
M Source/WebCore/page/ResizeObserver.h
Log Message:
-----------
[World Leaks] Investigate leaks in
LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size/
https://bugs.webkit.org/show_bug.cgi?id=300275
rdar://162081020
Reviewed by Ryosuke Niwa.
Document holds a RefPtr<m_resizeObserverForContainIntrinsicSize> which holds a
Vector<GCReachableRef<Element>>, which internally is a vector of RefPtr<Element>
causing a leak, which impacts approximately 15 tests. This is fixed by changing
the
vector to a Vector<WeakPtr<Element>>.
Test: fast/css/contain-intrinsic-size-does-not-leak.html
* LayoutTests/fast/css/contain-intrinsic-size-does-not-leak-expected.txt: Added.
* LayoutTests/fast/css/contain-intrinsic-size-does-not-leak.html: Added.
* LayoutTests/fast/css/resources/contain-intrinsic-size-leak-test.html: Added.
* Source/WebCore/bindings/js/JSResizeObserverCustom.cpp:
(WebCore::JSResizeObserver::visitAdditionalChildren):
* Source/WebCore/page/ResizeObserver.cpp:
(WebCore::ResizeObserver::observeInternal):
(WebCore::ResizeObserver::gatherObservations):
(WebCore::ResizeObserver::deliverObservations):
(WebCore::ResizeObserver::isReachableFromOpaqueRoots const):
(WebCore::ResizeObserver::removeAllTargets):
(WebCore::ResizeObserver::removeObservation):
* Source/WebCore/page/ResizeObserver.h:
(WebCore::ResizeObserver::WTF_REQUIRES_LOCK):
(WebCore::ResizeObserver::WTF_RETURNS_LOCK):
Canonical link: https://commits.webkit.org/301243@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
