Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 00591b21d6b64f611ab3c4c9988074edd9f03089
      
https://github.com/WebKit/WebKit/commit/00591b21d6b64f611ab3c4c9988074edd9f03089
  Author: Chris Dumez <cdu...@apple.com>
  Date:   2025-10-09 (Thu, 09 Oct 2025)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/bindings/js/JSDocumentCustom.cpp
    R Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp
    R Source/WebCore/bindings/js/JSXMLDocumentCustom.cpp
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/dom/Document.idl
    M Source/WebCore/dom/XMLDocument.idl
    M Source/WebCore/html/HTMLDocument.idl

  Log Message:
  -----------
  Drop Custom toJS() / toJSNewlyCreated() functions for Document, XMLDocument & 
HTMLDocument
https://bugs.webkit.org/show_bug.cgi?id=300427

Reviewed by Ryosuke Niwa.

Drop Custom toJS() / toJSNewlyCreated() functions for Document, XMLDocument & 
HTMLDocument
by extending the bindings generator support for these.

I had to add `[SkipVTableValidation]` to XMLDocument.idl and HTMLDocument.idl 
because the
generated vtable check would fail, presumably due to them having subclasses. 
Note that the
original custom bindings code had no vtable validation check so this check 
would have been
new after my change anyway.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/bindings/js/JSDocumentCustom.cpp:
(WebCore::createNewDocumentWrapper): Deleted.
(WebCore::toJSNewlyCreated): Deleted.
(WebCore::toJS): Deleted.
* Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp: Removed.
* Source/WebCore/bindings/js/JSXMLDocumentCustom.cpp: Removed.
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* Source/WebCore/dom/Document.idl:
* Source/WebCore/dom/XMLDocument.idl:
* Source/WebCore/html/HTMLDocument.idl:

Canonical link: https://commits.webkit.org/301291@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to