Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 722ac931d4b8ae3d78668516c604d62d8e215b75
https://github.com/WebKit/WebKit/commit/722ac931d4b8ae3d78668516c604d62d8e215b75
Author: Vitor Roriz <[email protected]>
Date: 2025-10-15 (Wed, 15 Oct 2025)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/fast/css/line-height-basics.html
M LayoutTests/fast/css/line-height-zoom-get-computed-style.html
M LayoutTests/fast/text/line-height-minimumFontSize-zoom.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/relative-units.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style.html
M LayoutTests/printing/page-rule-selection.html
M LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
M Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h
M Source/WebCore/page/PrintContext.cpp
M Source/WebCore/rendering/TextAutoSizing.cpp
M Source/WebCore/rendering/style/AutosizeStatus.cpp
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/style/StyleAdjuster.cpp
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/values/inline/StyleLineHeight.h
M Source/WebCore/style/values/text/StyleLetterSpacing.cpp
M Source/WebCore/style/values/text/StyleWordSpacing.cpp
Log Message:
-----------
[CSS Zoom] Fix zoom factor for line-height
rdar://162601748
https://bugs.webkit.org/show_bug.cgi?id=300699
Reviewed by Tim Nguyen and Alan Baradlay.
We want to store the unzoomed line-height value at RenderStyle
and the zoomeed value at FontCascade.
We are just handling line-height integration of zoom for
EvaluationTimeZoomEnabled here.
We are not handling font related units, which is tracked by another bug
(http://webkit.org/b/299816)
for that reason, we are explicitly disabling EvaluationTimeZoomEnabled for
tests that apply zoom
to elements that present line-height with font-related units (percentage, em,
rem...)
* LayoutTests/TestExpectations:
* LayoutTests/fast/css/line-height-basics.html:
* LayoutTests/fast/css/line-height-zoom-get-computed-style.html:
* LayoutTests/fast/text/line-height-minimumFontSize-zoom.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/relative-units.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style.html:
* LayoutTests/printing/page-rule-selection.html:
* LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm:
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::preferredLineHeight const):
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBoxInlines.h:
(WebCore::Layout::m_style):
* Source/WebCore/page/PrintContext.cpp:
(WebCore::PrintContext::pageProperty):
* Source/WebCore/rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* Source/WebCore/rendering/style/AutosizeStatus.cpp:
(WebCore::AutosizeStatus::probablyContainsASmallFixedNumberOfLines):
(WebCore::AutosizeStatus::computeStatus):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::isIdempotentTextAutosizingCandidate const):
(WebCore::RenderStyle::computeLineHeight const):
* Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustmentForTextAutosizing):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::zoomWithTextZoomFactor):
* Source/WebCore/style/values/inline/StyleLineHeight.h:
* Source/WebCore/style/values/text/StyleLetterSpacing.cpp:
(WebCore::Style::CSSValueConversion<LetterSpacing>::operator):
* Source/WebCore/style/values/text/StyleWordSpacing.cpp:
(WebCore::Style::CSSValueConversion<WordSpacing>::operator):
Canonical link: https://commits.webkit.org/301577@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
