Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a9a2e49a0006fb40a68ec14dd03bb009f1e7b17
https://github.com/WebKit/WebKit/commit/6a9a2e49a0006fb40a68ec14dd03bb009f1e7b17
Author: Adrian Taylor <[email protected]>
Date: 2025-10-17 (Fri, 17 Oct 2025)
Changed paths:
M CMakeLists.txt
M Source/cmake/WebKitMacros.cmake
A Tools/Scripts/swift/swiftc-wrapper.sh
Log Message:
-----------
CMake Swift build should ignore pthread
https://bugs.webkit.org/show_bug.cgi?id=300978
rdar://162856104
Reviewed by Jonathan Bedard.
This commit filters out any '-pthread' argument passed to swiftc compiler
invocations, by using a swiftc wrapper script. We're discussing a longer-term
fix with swift cmake experts, but this gets us building again for now.
Alternatives considered:
* Override cmake's macros which it uses to accumulate CFLAGS from
pkg-config output. Despite working with a cmake expert, I was unable
to successfully override the pkg_check_modules macro, which is where
this would need to happen.
* Alter all of WebKit's logic where it finds individual packages. There
are at least five packages which bring in a -pthread argument, and
possibly dozens more if individual components of gstreamer are considered.
Even if we chose to change each one of them, the discovery of these
packages is spread between WebKit cmake rules (which we can change)
and cmake's built-in rules (which we can't) so it's not clear that
we would actually be able to do this.
These solutions require further investigation and discussion, but for now,
a compiler wrapper resolves this issue.
It is necessarily a partial and temporary solution because there are other
arguments accumulated from pkg-config which make their way into swiftc,
e.g. -Werror.
Canonical link: https://commits.webkit.org/301716@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
