Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dd50ed74020270b2d08e8aff0f06811216df2bdd
https://github.com/WebKit/WebKit/commit/dd50ed74020270b2d08e8aff0f06811216df2bdd
Author: Elika Etemad <[email protected]>
Date: 2025-10-17 (Fri, 17 Oct 2025)
Changed paths:
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBlockFlow.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderGrid.h
M Source/WebCore/rendering/RenderMultiColumnSet.cpp
M Source/WebCore/rendering/RenderMultiColumnSet.h
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTable.h
M Source/WebCore/rendering/RenderTableSection.cpp
M Source/WebCore/rendering/svg/RenderSVGBlock.cpp
M Source/WebCore/rendering/svg/RenderSVGBlock.h
Log Message:
-----------
Clean up RenderBox overflow methods
https://bugs.webkit.org/show_bug.cgi?id=300835
rdar://162722242
Reviewed by Alan Baradlay.
The various computeOverflow/addOverflow methods are kinda tangled up. Clean it
up.
- Shifts method declarations to the correct superclass/subclass level
(adjusting names as necessary), and in the right section of the .h file.
- Simplifies parameters and sets us up for additional options in the future.
- Encapsulates memory management of m_overflow.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::addOverflowFromOutOfFlowBoxes):
(WebCore::RenderBlock::addVisualOverflowFromTheme):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::addOverflowFromChildren): Deleted.
(WebCore::RenderBlock::addOverflowFromBlockChildren): Deleted.
* Source/WebCore/rendering/RenderBlock.h:
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::addOverflowFromInlineChildren): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::addOverflowFromInFlowChildren):
* Source/WebCore/rendering/RenderBlockFlow.h:
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::addOverflowFromInFlowChildren):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::addOverflowFromInFlowChildren):
(WebCore::RenderBox::addOverflowFromContainedBox):
(WebCore::RenderBox::addOverflowWithRendererOffset):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::percentageLogicalHeightIsResolvable const):
(WebCore::RenderBox::hasUnsplittableScrollingOverflow const):
(WebCore::RenderBox::isUnsplittableForPagination const):
(WebCore::RenderBox::addOverflowFromInFlowChildOrAbsolutePositionedDescendant):
Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::contentOverflowRect const):
(WebCore::RenderGrid::computeOverflow): Deleted.
* Source/WebCore/rendering/RenderGrid.h:
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::addOverflowFromInFlowChildren):
(WebCore::RenderMultiColumnSet::addOverflowFromChildren): Deleted.
* Source/WebCore/rendering/RenderMultiColumnSet.h:
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::addOverflowFromInFlowChildren):
(WebCore::RenderTable::addOverflowFromChildren): Deleted.
* Source/WebCore/rendering/RenderTable.h:
(WebCore::RenderTable::addOverflowFromInFlowChildren):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::computeOverflowFromCells):
* Source/WebCore/rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::computeOverflow):
* Source/WebCore/rendering/svg/RenderSVGBlock.h:
Canonical link: https://commits.webkit.org/301714@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
