Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 680ba7115028f728b2ffb3c00fb615dfc6805ffa
https://github.com/WebKit/WebKit/commit/680ba7115028f728b2ffb3c00fb615dfc6805ffa
Author: BJ Burg <[email protected]>
Date: 2025-10-13 (Mon, 13 Oct 2025)
Changed paths:
M Source/JavaScriptCore/inspector/ContentSearchUtilities.h
M Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/inspector/InspectorAuditResourcesObject.cpp
A Source/WebCore/inspector/InspectorNetworkIntercept.cpp
A Source/WebCore/inspector/InspectorNetworkIntercept.h
A Source/WebCore/inspector/InspectorResourceType.h
A Source/WebCore/inspector/InspectorResourceUtilities.cpp
A Source/WebCore/inspector/InspectorResourceUtilities.h
M Source/WebCore/inspector/InspectorStyleSheet.cpp
M Source/WebCore/inspector/InspectorStyleSheet.h
A Source/WebCore/inspector/InspectorThreadableLoaderClient.cpp
A Source/WebCore/inspector/InspectorThreadableLoaderClient.h
M Source/WebCore/inspector/NetworkResourcesData.cpp
M Source/WebCore/inspector/NetworkResourcesData.h
M Source/WebCore/inspector/agents/InspectorDOMAgent.h
M Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp
M Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp
M Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp
M Source/WebCore/inspector/agents/InspectorNetworkAgent.h
M Source/WebCore/inspector/agents/InspectorPageAgent.cpp
M Source/WebCore/inspector/agents/InspectorPageAgent.h
M Source/WebCore/inspector/agents/page/PageDebuggerAgent.cpp
Log Message:
-----------
Web Inspector: reduce amount of shared code in InspectorNetworkAgent and
InspectorPageAgent
https://bugs.webkit.org/show_bug.cgi?id=300051
Reviewed by Devin Rousso.
In preparation for Site Isolation refactorings in these agents, move static
helper
functions, nested classes, and other shared code out of the agent files where
possible.
Method implementations have been left alone for now. Many of them need to be
improved
in order to pass SaferCPP checks; this work is tracked by
https://webkit.org/b/300125.
For site isolation, we will need to coordinate the intercept structs between
UIProcess
and web content processes. The same infrastructure will be used to implement
network
interception for WebDriver Bidi. So it moves now, despite being used from only
NetworkAgent.
* Source/JavaScriptCore/inspector/ContentSearchUtilities.h:
* Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/inspector/InspectorAuditResourcesObject.cpp:
(WebCore::InspectorAuditResourcesObject::getResources):
(WebCore::InspectorAuditResourcesObject::getResourceContent):
* Source/WebCore/inspector/InspectorNetworkIntercept.cpp: Added.
(Inspector::Intercept::matches):
* Source/WebCore/inspector/InspectorNetworkIntercept.h: Added.
(Inspector::Intercept::operator== const):
(Inspector::PendingInterceptRequest::PendingInterceptRequest):
(Inspector::PendingInterceptRequest::continueWithOriginalRequest):
(Inspector::PendingInterceptRequest::continueWithRequest):
(Inspector::PendingInterceptResponse::PendingInterceptResponse):
(Inspector::PendingInterceptResponse::~PendingInterceptResponse):
(Inspector::PendingInterceptResponse::originalResponse):
(Inspector::PendingInterceptResponse::respondWithOriginalResponse):
(Inspector::PendingInterceptResponse::respond):
* Source/WebCore/inspector/InspectorResourceType.h: Added.
* Source/WebCore/inspector/InspectorResourceUtilities.cpp: Added.
(Inspector::ResourceUtilities::resourceTypeToProtocol):
(Inspector::ResourceUtilities::decodeBuffer):
(Inspector::ResourceUtilities::dataContent):
(Inspector::ResourceUtilities::sharedBufferContent):
(Inspector::ResourceUtilities::mainResourceContent):
(Inspector::ResourceUtilities::resourceContent):
(Inspector::ResourceUtilities::sourceMapURLForResource):
(Inspector::ResourceUtilities::cachedResource):
(Inspector::ResourceUtilities::inspectorResourceType):
(Inspector::ResourceUtilities::cachedResourceTypeToProtocol):
(Inspector::ResourceUtilities::findFrameWithSecurityOrigin):
(Inspector::ResourceUtilities::assertDocumentLoader):
(Inspector::ResourceUtilities::shouldTreatAsText):
(Inspector::ResourceUtilities::createTextDecoder):
(Inspector::ResourceUtilities::textContentForCachedResource):
(Inspector::ResourceUtilities::cachedResourceContent):
* Source/WebCore/inspector/InspectorResourceUtilities.h: Added.
* Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText const):
* Source/WebCore/inspector/InspectorThreadableLoaderClient.cpp: Added.
(Inspector::InspectorThreadableLoaderClient::didReceiveResponse):
(Inspector::InspectorThreadableLoaderClient::didReceiveData):
(Inspector::InspectorThreadableLoaderClient::didFinishLoading):
(Inspector::InspectorThreadableLoaderClient::didFail):
(Inspector::InspectorThreadableLoaderClient::setLoader):
(Inspector::InspectorThreadableLoaderClient::dispose):
* Source/WebCore/inspector/InspectorThreadableLoaderClient.h: Added.
* Source/WebCore/inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::resourceCreated):
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
* Source/WebCore/inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::type const):
(WebCore::NetworkResourcesData::ResourceData::setType):
* Source/WebCore/inspector/agents/InspectorDOMAgent.h:
* Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::findStorageArea):
* Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
* Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::resourceTypeForCachedResource):
(WebCore::resourceTypeForLoadType):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didFinishLoading):
(WebCore::InspectorNetworkAgent::didFailLoading):
(WebCore::InspectorNetworkAgent::didReceiveScriptResponse):
(WebCore::InspectorNetworkAgent::didReceiveThreadableLoaderResponse):
(WebCore::InspectorNetworkAgent::willDestroyCachedResource):
(WebCore::networkStageFromProtocol):
(WebCore::InspectorNetworkAgent::shouldIntercept):
(WebCore::InspectorNetworkAgent::getResponseBody):
(WebCore::InspectorNetworkAgent::addInterception):
(WebCore::InspectorNetworkAgent::removeInterception):
(WebCore::textContentForResourceData):
(WebCore::InspectorNetworkAgent::shouldTreatAsText): Deleted.
(WebCore::InspectorNetworkAgent::createTextDecoder): Deleted.
(WebCore::InspectorNetworkAgent::textContentForCachedResource): Deleted.
(WebCore::InspectorNetworkAgent::cachedResourceContent): Deleted.
(WebCore::InspectorNetworkAgent::Intercept::matches): Deleted.
* Source/WebCore/inspector/agents/InspectorNetworkAgent.h:
(WebCore::InspectorNetworkAgent::PendingInterceptRequest::PendingInterceptRequest):
Deleted.
(WebCore::InspectorNetworkAgent::PendingInterceptRequest::continueWithOriginalRequest):
Deleted.
(WebCore::InspectorNetworkAgent::PendingInterceptRequest::continueWithRequest):
Deleted.
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::PendingInterceptResponse):
Deleted.
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::~PendingInterceptResponse):
Deleted.
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::originalResponse):
Deleted.
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::respondWithOriginalResponse):
Deleted.
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::respond): Deleted.
(WebCore::InspectorNetworkAgent::Intercept::operator== const): Deleted.
* Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
(WebCore::decodeBuffer): Deleted.
(WebCore::InspectorPageAgent::mainResourceContent): Deleted.
(WebCore::InspectorPageAgent::sharedBufferContent): Deleted.
(WebCore::InspectorPageAgent::dataContent): Deleted.
(): Deleted.
(WebCore::InspectorPageAgent::resourceContent): Deleted.
(WebCore::InspectorPageAgent::sourceMapURLForResource): Deleted.
(WebCore::InspectorPageAgent::cachedResource): Deleted.
(WebCore::InspectorPageAgent::resourceTypeJSON): Deleted.
(WebCore::InspectorPageAgent::inspectorResourceType): Deleted.
(WebCore::InspectorPageAgent::cachedResourceTypeJSON): Deleted.
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Deleted.
(WebCore::InspectorPageAgent::assertDocumentLoader): Deleted.
* Source/WebCore/inspector/agents/InspectorPageAgent.h:
* Source/WebCore/inspector/agents/page/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
Canonical link: https://commits.webkit.org/301444@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
