Title: [113426] trunk
- Revision
- 113426
- Author
- [email protected]
- Date
- 2012-04-06 05:07:11 -0700 (Fri, 06 Apr 2012)
Log Message
[Chromium] Web Inspector: getEventListeners(window) crashes on NTP
https://bugs.webkit.org/show_bug.cgi?id=83353
Reviewed by Pavel Feldman.
Source/WebCore:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::getEventListenersCallback):
LayoutTests:
* inspector/console/command-line-api-getEventListeners-expected.txt:
* inspector/console/command-line-api-getEventListeners.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (113425 => 113426)
--- trunk/LayoutTests/ChangeLog 2012-04-06 10:37:08 UTC (rev 113425)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 12:07:11 UTC (rev 113426)
@@ -1,3 +1,13 @@
+2012-04-06 Andrey Kosyakov <[email protected]>
+
+ [Chromium] Web Inspector: getEventListeners(window) crashes on NTP
+ https://bugs.webkit.org/show_bug.cgi?id=83353
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/console/command-line-api-getEventListeners-expected.txt:
+ * inspector/console/command-line-api-getEventListeners.html:
+
2012-04-06 Csaba Osztrogonác <[email protected]>
[Qt][Mac] Skip new failing tests to paing the bot green.
Modified: trunk/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt (113425 => 113426)
--- trunk/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt 2012-04-06 10:37:08 UTC (rev 113425)
+++ trunk/LayoutTests/inspector/console/command-line-api-getEventListeners-expected.txt 2012-04-06 12:07:11 UTC (rev 113426)
@@ -51,4 +51,6 @@
undefined
- undefined -
undefined
+- window -
+undefined
Modified: trunk/LayoutTests/inspector/console/command-line-api-getEventListeners.html (113425 => 113426)
--- trunk/LayoutTests/inspector/console/command-line-api-getEventListeners.html 2012-04-06 10:37:08 UTC (rev 113425)
+++ trunk/LayoutTests/inspector/console/command-line-api-getEventListeners.html 2012-04-06 12:07:11 UTC (rev 113426)
@@ -86,6 +86,8 @@
output(typeof getEventListeners(null));
output("- undefined -");
output(typeof getEventListeners(undefined));
+ output("- window -");
+ output(typeof getEventListeners(window));
}
</script>
Modified: trunk/Source/WebCore/ChangeLog (113425 => 113426)
--- trunk/Source/WebCore/ChangeLog 2012-04-06 10:37:08 UTC (rev 113425)
+++ trunk/Source/WebCore/ChangeLog 2012-04-06 12:07:11 UTC (rev 113426)
@@ -1,3 +1,13 @@
+2012-04-06 Andrey Kosyakov <[email protected]>
+
+ [Chromium] Web Inspector: getEventListeners(window) crashes on NTP
+ https://bugs.webkit.org/show_bug.cgi?id=83353
+
+ Reviewed by Pavel Feldman.
+
+ * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+ (WebCore::V8InjectedScriptHost::getEventListenersCallback):
+
2012-04-06 Kent Tamura <[email protected]>
Touch ChromeClient.h to fix Chromium build.
Modified: trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (113425 => 113426)
--- trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp 2012-04-06 10:37:08 UTC (rev 113425)
+++ trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp 2012-04-06 12:07:11 UTC (rev 113426)
@@ -219,7 +219,7 @@
v8::HandleScope handleScope;
v8::Local<v8::Value> value = args[0];
- if (!value->IsObject())
+ if (!V8Node::HasInstance(value))
return v8::Undefined();
Node* node = V8Node::toNative(value->ToObject());
if (!node)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
