Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a797d90e51ab84dde8d6cb343ac13ee43df735d2
https://github.com/WebKit/WebKit/commit/a797d90e51ab84dde8d6cb343ac13ee43df735d2
Author: Brent Fulgham <[email protected]>
Date: 2025-10-15 (Wed, 15 Oct 2025)
Changed paths:
M LayoutTests/TestExpectations
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/box-shadow-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/box-shadow.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/filters-drop-shadow-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/filters-drop-shadow.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/box-shadow-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/filters-drop-shadow-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style.html
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+TextDecoration.cpp
M Source/WebCore/css/values/borders/CSSBoxShadow.h
M Source/WebCore/css/values/filter-effects/CSSDropShadowFunction.h
M Source/WebCore/css/values/text-decoration/CSSTextShadow.h
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/FontAttributeChanges.cpp
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/rendering/BackgroundPainter.cpp
M Source/WebCore/rendering/EllipsisBoxPainter.cpp
M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/TextBoxPainter.h
M Source/WebCore/rendering/TextDecorationPainter.cpp
M Source/WebCore/rendering/TextPainter.cpp
M Source/WebCore/rendering/svg/RenderSVGBlock.cpp
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp
M Source/WebCore/style/values/borders/StyleBoxShadow.h
M Source/WebCore/style/values/borders/StyleShadow.h
M Source/WebCore/style/values/filter-effects/StyleDropShadowFunction.cpp
M Source/WebCore/style/values/text-decoration/StyleTextShadow.cpp
M Source/WebCore/style/values/text-decoration/StyleTextShadow.h
Log Message:
-----------
[CSS Zoom] Apply zoom factor to text-shadow, box-shadow, and drop-shadow
https://bugs.webkit.org/show_bug.cgi?id=300577
rdar://162463179
Reviewed by Tim Nguyen.
Update TextShadow, BoxShadow, and DropShadow to use the new strong type system,
and apply zoom factor at evaluation-time.
This change consists of changing Length<> to Length<CSS:UnzoomedAll> in shadow
related data, Length<Nonnegative> to Length<CSS::NonnegativeUnzoomed> in blur
related data, and threading the Style zoom state through more of the callstack.
Test: imported/w3c/web-platform-tests/css/css-viewport/zoom/box-shadow.html
imported/w3c/web-platform-tests/css/css-viewport/zoom/filters-drop-shadow.html
imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style.html
imported/w3c/web-platform-tests/css/css-viewport/zoom/text-shadow.html
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/box-shadow-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/box-shadow.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/filters-drop-shadow-expected.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/filters-drop-shadow.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/box-shadow-ref.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/reference/filters-drop-shadow-ref.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-viewport/zoom/svg-computed-style.html:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Background.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleUnresolvedBoxShadow):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFilterDropShadow):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+TextDecoration.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleUnresolvedTextShadow):
* Source/WebCore/css/values/borders/CSSBoxShadow.h:
* Source/WebCore/css/values/filter-effects/CSSDropShadowFunction.h:
* Source/WebCore/css/values/text-decoration/CSSTextShadow.h:
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::fontAttributesAtSelectionStart):
* Source/WebCore/editing/FontAttributeChanges.cpp:
(WebCore::cssValueForTextShadow):
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::computeInkOverflowForInlineLevelBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::applyBoxShadowForBackground):
(WebCore::BackgroundPainter::paintBoxShadow const):
* Source/WebCore/rendering/EllipsisBoxPainter.cpp:
(WebCore::EllipsisBoxPainter::paint):
* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::addTextBoxVisualOverflow):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::applyVisualEffectOverflow const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
* Source/WebCore/rendering/TextBoxPainter.h:
(WebCore::TextBoxPainter::rotateShadowOffset):
* Source/WebCore/rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::paintBackgroundDecorations):
* Source/WebCore/rendering/TextPainter.cpp:
* Source/WebCore/rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::computeOverflow):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::repaintRectInLocalCoordinates const):
(WebCore::RenderSVGText::updatePositionAndOverflow):
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGModelObject.cpp:
(WebCore::adjustRectForOutlineAndShadow):
(WebCore::LegacyRenderSVGModelObject::outlineBoundsForRepaint const):
* Source/WebCore/style/values/borders/StyleBoxShadow.h:
(WebCore::Style::paintingSpread):
* Source/WebCore/style/values/borders/StyleShadow.h:
(WebCore::Style::requires):
(WebCore::Style::paintingExtent):
(WebCore::Style::paintingExtentAndSpread):
(WebCore::Style::shadowOutsetExtent):
(WebCore::Style::shadowInsetExtent):
(WebCore::Style::shadowHorizontalExtent):
(WebCore::Style::shadowVerticalExtent):
(WebCore::Style::shadowBlockDirectionExtent):
(WebCore::Style::shadowInlineDirectionExtent):
(WebCore::Style::adjustRectForShadow):
* Source/WebCore/style/values/filter-effects/StyleDropShadowFunction.cpp:
(WebCore::Style::toCSSDropShadow):
(WebCore::Style::createFilterOperation):
* Source/WebCore/style/values/text-decoration/StyleTextShadow.cpp:
(WebCore::Style::ToStyle<CSS::TextShadow>::operator):
* Source/WebCore/style/values/text-decoration/StyleTextShadow.h:
(WebCore::Style::paintingSpread):
Canonical link: https://commits.webkit.org/301596@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
