Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d46abace846948d54a798fb965ccefeea1e54dbd
https://github.com/WebKit/WebKit/commit/d46abace846948d54a798fb965ccefeea1e54dbd
Author: Nikolas Zimmermann <[email protected]>
Date: 2025-10-06 (Mon, 06 Oct 2025)
Changed paths:
M Source/WebKit/PlatformPlayStation.cmake
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedSceneState.h
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h
A
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostPlayStation.cpp
A
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostPlayStation.h
M
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.cpp
M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.h
A
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositorPlayStation.cpp
A
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositorPlayStation.h
R
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitor.cpp
R
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitor.h
A
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitorPlayStation.cpp
A
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitorPlayStation.h
Log Message:
-----------
[GTK][WPE] Get rid of non-DisplayLink code path
https://bugs.webkit.org/show_bug.cgi?id=300044
Reviewed by Fujii Hironori.
The "#if !HAVE(DISPLAY_LINK)" code path is no longer used for Gtk/WPE ports.
Only the PlayStation port still uses it by default -- therefore split
LayerTreeHost/ThreadedCompositor into parts that use only the
"#if !HAVE(DISPLAY_LINK)" code path (with ifdefs removed) in
LayeTreeHostPlayStation/ThreadedCompositorPlayStation.
This allows us to remove the code path entirely from our LayerTreeHost
and ThreadedCompositor. We can also remove all PLATFORM(WPE) || PLATFORM(GTK)
checks since those classes are now exclusively used by Gtk/WPE ports,
simplifying the code.
Covered by existing tests.
* Source/WebKit/PlatformPlayStation.cmake:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CoordinatedSceneState.h:
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::LayerTreeHost):
(WebKit::LayerTreeHost::flushLayers):
(WebKit::LayerTreeHost::layerFlushTimerFired):
(WebKit::LayerTreeHost::forceRepaint):
(WebKit::LayerTreeHost::forceRepaintAsync):
(WebKit::LayerTreeHost::ensureDrawing):
(WebKit::LayerTreeHost::didComposite):
(WebKit::LayerTreeHost::createDisplayRefreshMonitor): Deleted.
(WebKit::LayerTreeHost::requestDisplayRefreshMonitorUpdate): Deleted.
(WebKit::LayerTreeHost::handleDisplayRefreshMonitorUpdate): Deleted.
(WebKit::LayerTreeHost::renderNextFrame): Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostPlayStation.cpp:
Copied from
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp.
(WebKit::LayerTreeHost::LayerTreeHost):
(WebKit::LayerTreeHost::~LayerTreeHost):
(WebKit::LayerTreeHost::setLayerTreeStateIsFrozen):
(WebKit::LayerTreeHost::scheduleLayerFlush):
(WebKit::LayerTreeHost::cancelPendingLayerFlush):
(WebKit::LayerTreeHost::flushLayers):
(WebKit::LayerTreeHost::layerFlushTimerFired):
(WebKit::LayerTreeHost::updateRootLayer):
(WebKit::LayerTreeHost::setRootCompositingLayer):
(WebKit::LayerTreeHost::setViewOverlayRootLayer):
(WebKit::LayerTreeHost::forceRepaint):
(WebKit::LayerTreeHost::forceRepaintAsync):
(WebKit::LayerTreeHost::sizeDidChange):
(WebKit::LayerTreeHost::pauseRendering):
(WebKit::LayerTreeHost::resumeRendering):
(WebKit::LayerTreeHost::graphicsLayerFactory):
(WebKit::LayerTreeHost::visibleContentsRect const):
(WebKit::LayerTreeHost::backgroundColorDidChange):
(WebKit::LayerTreeHost::attachLayer):
(WebKit::LayerTreeHost::detachLayer):
(WebKit::LayerTreeHost::notifyCompositionRequired):
(WebKit::LayerTreeHost::isCompositionRequiredOrOngoing const):
(WebKit::LayerTreeHost::requestComposition):
(WebKit::LayerTreeHost::compositingRunLoop const):
(WebKit::LayerTreeHost::paintingEngine):
(WebKit::LayerTreeHost::imageBackingStore):
(WebKit::LayerTreeHost::createGraphicsLayer):
(WebKit::LayerTreeHost::createDisplayRefreshMonitor):
(WebKit::LayerTreeHost::requestDisplayRefreshMonitorUpdate):
(WebKit::LayerTreeHost::handleDisplayRefreshMonitorUpdate):
(WebKit::LayerTreeHost::willRenderFrame):
(WebKit::LayerTreeHost::didRenderFrame):
(WebKit::LayerTreeHost::didComposite):
(WebKit::LayerTreeHost::commitSceneState):
(WebKit::LayerTreeHost::renderNextFrame):
(WebKit::LayerTreeHost::notifyFrameDamageForTesting):
(WebKit::LayerTreeHost::resetDamageHistoryForTesting):
(WebKit::LayerTreeHost::foreachRegionInDamageHistoryForTesting):
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostPlayStation.h:
Copied from
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::create):
(WebKit::ThreadedCompositor::ThreadedCompositor):
(WebKit::m_compositingRunLoop):
(WebKit::m_didRenderFrameTimer):
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::frameComplete):
(WebKit::ThreadedCompositor::didRenderFrameTimerFired):
(WebKit::m_displayRefreshMonitor): Deleted.
(WebKit::ThreadedCompositor::displayRefreshMonitor const): Deleted.
(WebKit::ThreadedCompositor::displayUpdateFired): Deleted.
(WebKit::ThreadedCompositor::sceneUpdateFinished): Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.h:
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositorPlayStation.cpp:
Copied from
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.cpp.
(WebKit::ThreadedCompositor::create):
(WebKit::ThreadedCompositor::ThreadedCompositor):
(WebKit::m_compositingRunLoop):
(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::surfaceID const):
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::suspend):
(WebKit::ThreadedCompositor::resume):
(WebKit::ThreadedCompositor::isActive const):
(WebKit::ThreadedCompositor::backgroundColorDidChange):
(WebKit::ThreadedCompositor::setSize):
(WebKit::ThreadedCompositor::setDamagePropagationFlags):
(WebKit::ThreadedCompositor::enableFrameDamageNotificationForTesting):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::paintToCurrentGLContext):
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::requestComposition):
(WebKit::ThreadedCompositor::scheduleUpdate):
(WebKit::ThreadedCompositor::runLoop):
(WebKit::ThreadedCompositor::frameComplete):
(WebKit::ThreadedCompositor::didRenderFrameTimerFired):
(WebKit::ThreadedCompositor::displayRefreshMonitor const):
(WebKit::ThreadedCompositor::displayUpdateFired):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::updateSceneAttributes):
(WebKit::ThreadedCompositor::initializeFPSCounter):
(WebKit::ThreadedCompositor::updateFPSCounter):
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositorPlayStation.h:
Copied from
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedCompositor.h.
(WebKit::ThreadedCompositor::fps const):
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitorPlayStation.cpp:
Renamed from
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitor.cpp.
*
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitorPlayStation.h:
Renamed from
Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/ThreadedDisplayRefreshMonitor.h.
Canonical link: https://commits.webkit.org/301052@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
