Title: [113429] trunk/Source/WebKit/blackberry
- Revision
- 113429
- Author
- [email protected]
- Date
- 2012-04-06 05:53:37 -0700 (Fri, 06 Apr 2012)
Log Message
[BlackBerry] Text selection - Can't select texts
https://bugs.webkit.org/show_bug.cgi?id=83355
Fix the problem of not sending out the result of the function
SelectionHandler::regionForTextQuads(). This regression issue
is introduced by the git commit f9446b7d671d48a833ab0acf12b1e20637e0a910.
Patch by Sean Wang <[email protected]> on 2012-04-06
Reviewed by George Staikos.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
Add code to return the function result.
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (113428 => 113429)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-04-06 12:49:55 UTC (rev 113428)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-04-06 12:53:37 UTC (rev 113429)
@@ -1,3 +1,18 @@
+2012-04-06 Sean Wang <[email protected]>
+
+ [BlackBerry] Text selection - Can't select texts
+ https://bugs.webkit.org/show_bug.cgi?id=83355
+
+ Fix the problem of not sending out the result of the function
+ SelectionHandler::regionForTextQuads(). This regression issue
+ is introduced by the git commit f9446b7d671d48a833ab0acf12b1e20637e0a910.
+
+ Reviewed by George Staikos.
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
+ Add code to return the function result.
+
2012-04-05 Jason Liu <[email protected]>
[BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (113428 => 113429)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-04-06 12:49:55 UTC (rev 113428)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-04-06 12:53:37 UTC (rev 113429)
@@ -134,13 +134,12 @@
// Convert the text quads into a more platform friendy
// IntRectRegion and adjust for subframes.
- std::vector<Platform::IntRect> adjustedIntRects;
Platform::IntRect selectionBoundingBox;
for (unsigned i = 0; i < quadList.size(); i++) {
WebCore::IntRect enclosingRect = quadList[i].enclosingBoundingBox();
enclosingRect.intersect(frameRect);
enclosingRect.move(framePosition.x(), framePosition.y());
- adjustedIntRects.push_back(enclosingRect);
+ region = unionRegions(region, IntRectRegion(enclosingRect));
// Clip to the visible content.
if (clippingRect.location() != DOMSupport::InvalidPoint)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
