Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ae143edf7fbed31bd11942eabc075be75ad98f72
https://github.com/WebKit/WebKit/commit/ae143edf7fbed31bd11942eabc075be75ad98f72
Author: Rupin Mittal <[email protected]>
Date: 2025-10-15 (Wed, 15 Oct 2025)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/interfaces/html.idl
A LayoutTests/navigation-api/navigation-object-is-replaceable-expected.txt
A LayoutTests/navigation-api/navigation-object-is-replaceable.html
M Source/WebCore/page/DOMWindow.idl
Log Message:
-----------
Safari Technology Preview 226 breaks espn.com title bar
https://bugs.webkit.org/show_bug.cgi?id=297721
rdar://158951219
Reviewed by Chris Dumez and Anne van Kesteren.
With the Navigation API enabled, the ESPN title bar is empty instead of
containing the tab buttons like it should.
The issue is that espn.com re-assigns the "navigation" variable to hold
these items in this function:
preRender: function(type, navCached, defaultNavData) {
...
navigation = defaultNavData.navigation
...
espn_ui.Helpers.nav.items = navigation.items
...
}
But with the Navigation API enabled, the "navigation" variable is reserved
for accessing that API and is not replaceable. So this re-assignment fails
and the title bar ends up empty.
The spec does not say that "navigation" should be replaceable. But this is
breaking a live site and Chrome does allow it to be replaceable, so we fix this
by making it replaceable in WebKit too. I have confirmed that this does fix
the ESPN title bar locally.
Associated spec issue: https://github.com/whatwg/html/pull/11786
I've added a new layout test to check this:
navigation-api/navigation-object-is-replaceable.html
* LayoutTests/imported/w3c/web-platform-tests/interfaces/html.idl:
* LayoutTests/imported/w3c/web-platform-tests/interfaces/html.idl:
* LayoutTests/navigation-api/navigation-object-is-replaceable-expected.txt:
Added.
* LayoutTests/navigation-api/navigation-object-is-replaceable.html: Added.
* Source/WebCore/page/DOMWindow.idl:
Canonical link: https://commits.webkit.org/301607@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
