Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0df86099faff39273edfb3f0a69df127919bcdd2
https://github.com/WebKit/WebKit/commit/0df86099faff39273edfb3f0a69df127919bcdd2
Author: Richard Robinson <[email protected]>
Date: 2025-10-10 (Fri, 10 Oct 2025)
Changed paths:
M Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig
M Source/JavaScriptCore/wasm/js/WebAssemblyBuiltin.cpp
M Source/JavaScriptCore/wasm/js/WebAssemblyBuiltin.h
M Source/JavaScriptCore/wasm/js/WebAssemblyCompileOptions.cpp
Log Message:
-----------
[Swift in WebKit] Use the 'builtin' module verifier for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=300284
rdar://162087188
Reviewed by Daniel Liu.
Opt-in to the builtin module verifier for JSC, which offers better correctness
and performance.
Consequently, this reveals a correctness issue where a symbol in JSC was named
`check`, which conflicts
with a macro definition in a dependency in some configurations. Historical
workarounds were made to stop
this from happening previously, however such workarounds are invalid and the
module verifier now catches these.
Fix by renaming `check` to `isValid`.
* Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
* Source/JavaScriptCore/wasm/js/WebAssemblyBuiltin.cpp:
(JSC::WebAssemblyArrayMutI16TypeExpectation::isValid const):
(JSC::WebAssemblyBuiltinSignature::isValid const):
(JSC::WebAssemblyArrayMutI16TypeExpectation::check const): Deleted.
(JSC::WebAssemblyBuiltinSignature::check const): Deleted.
* Source/JavaScriptCore/wasm/js/WebAssemblyBuiltin.h:
(JSC::WebAssemblyBuiltinValueTypeExpectation::isValid const):
(JSC::WebAssemblyBuiltinExternrefTypeExpectation::isValid const):
(JSC::WebAssemblyBuiltinValueTypeExpectation::check const): Deleted.
(JSC::WebAssemblyBuiltinExternrefTypeExpectation::check const): Deleted.
* Source/JavaScriptCore/wasm/js/WebAssemblyCompileOptions.cpp:
(JSC::WebAssemblyCompileOptions::validateImportForBuiltinSetNames const):
Canonical link: https://commits.webkit.org/301338@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
