Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 61c7aa15477cdcc0925925cc26e328419fdc9f1e
https://github.com/WebKit/WebKit/commit/61c7aa15477cdcc0925925cc26e328419fdc9f1e
Author: Sam Weinig <[email protected]>
Date: 2025-10-06 (Mon, 06 Oct 2025)
Changed paths:
M Source/WebCore/Headers.cmake
M
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/ViewTimeline.cpp
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/css/values/CSSValueConcepts.h
M Source/WebCore/page/IntersectionObserver.cpp
M Source/WebCore/rendering/RenderTreeAsText.cpp
M Source/WebCore/rendering/style/BorderData.cpp
M Source/WebCore/rendering/style/BorderValue.cpp
M Source/WebCore/rendering/style/OutlineValue.cpp
M Source/WebCore/rendering/style/RenderStyle.h
M Source/WebCore/rendering/style/RenderStyleInlines.h
M Source/WebCore/rendering/style/RenderStyleSetters.h
M Source/WebCore/rendering/style/SVGRenderStyle.cpp
M Source/WebCore/rendering/style/SVGRenderStyle.h
M Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp
M Source/WebCore/rendering/style/StyleAppleColorFilterData.cpp
M Source/WebCore/rendering/style/StyleBoxData.cpp
M Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.cpp
M Source/WebCore/rendering/style/StyleFilterData.cpp
M Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp
M Source/WebCore/rendering/style/StyleFontData.cpp
M Source/WebCore/rendering/style/StyleGridData.cpp
M Source/WebCore/rendering/style/StyleInheritedData.cpp
M Source/WebCore/rendering/style/StyleMarqueeData.cpp
M Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp
M Source/WebCore/rendering/style/StyleMultiColData.cpp
M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
M Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
M Source/WebCore/rendering/style/StyleSurroundData.cpp
M Source/WebCore/rendering/style/StyleTransformData.cpp
M Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleExtractorConverter.h
M Source/WebCore/style/StyleExtractorSerializer.h
M Source/WebCore/style/StyleInterpolationWrappers.h
M Source/WebCore/style/values/StyleValueTypes.h
M Source/WebCore/style/values/animations/StyleAnimation.cpp
M Source/WebCore/style/values/backgrounds/StyleBackgroundLayer.cpp
M Source/WebCore/style/values/backgrounds/StyleBorderImage.cpp
M Source/WebCore/style/values/color/StyleDynamicRangeLimitMix.cpp
M Source/WebCore/style/values/color/StyleRelativeColor.h
M Source/WebCore/style/values/grid/StyleGridPosition.cpp
M Source/WebCore/style/values/grid/StyleGridTemplateList.cpp
M Source/WebCore/style/values/masking/StyleMaskBorder.cpp
M Source/WebCore/style/values/masking/StyleMaskLayer.cpp
M Source/WebCore/style/values/motion/StyleOffsetPosition.cpp
M Source/WebCore/style/values/motion/StyleOffsetRotate.cpp
M
Source/WebCore/style/values/primitives/StylePrimitiveKeyword+CSSValueConversion.h
M
Source/WebCore/style/values/primitives/StylePrimitiveKeyword+CSSValueCreation.h
A Source/WebCore/style/values/primitives/StylePrimitiveKeyword+Logging.h
M
Source/WebCore/style/values/primitives/StylePrimitiveKeyword+Serialization.h
A
Source/WebCore/style/values/primitives/StylePrimitiveKeyword+ValueRepresentationNeeded.h
M Source/WebCore/style/values/scroll-animations/StyleViewFunction.cpp
M Source/WebCore/style/values/shapes/StylePathOperationWrappers.cpp
A Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.cpp
A Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.h
A Source/WebCore/style/values/svg/StyleSVGGlyphOrientationVertical.cpp
A Source/WebCore/style/values/svg/StyleSVGGlyphOrientationVertical.h
M
Source/WebCore/style/values/transforms/functions/StyleMatrix3DTransformFunction.cpp
M
Source/WebCore/style/values/transforms/functions/StyleMatrixTransformFunction.cpp
M
Source/WebCore/style/values/transforms/functions/StylePerspectiveTransformFunction.cpp
M
Source/WebCore/style/values/transforms/functions/StyleRotateTransformFunction.cpp
M
Source/WebCore/style/values/transforms/functions/StyleScaleTransformFunction.cpp
M
Source/WebCore/style/values/transforms/functions/StyleSkewTransformFunction.cpp
M
Source/WebCore/style/values/transforms/functions/StyleTranslateTransformFunction.cpp
M Source/WebCore/style/values/transitions/StyleTransition.cpp
Log Message:
-----------
[Style] Convert the 'glyph-orientation-*' properties to strong style types
https://bugs.webkit.org/show_bug.cgi?id=300064
Reviewed by Darin Adler.
Converts the 'glyph-orientation-horizontal' and 'glyph-orientation-vertical'
properties to strong style types.
To make properties like these, ones that can represented purely as `enum`,
work with strong style types, a new interface, `ValueRepresentation`, has
been added that allows converting the enum to its counterpart. This allows
us to implement a single interface and getting CSSValueCreation, Serialization
and Logging all for free. I expect this interface to evolve as we convert
more `enum` properties (for example, should we have a bidirectional mapping
of enum values <-> CSSValueIDs for simpler conversions, probably), but this
gives us a good starting out point.
To make it clear which enums still need `ValueRepresentation` conformance,
enums that don't have it (and are used with the style system) will cause
a compile error unless they are added to the list in
StylePrimitiveKeyword+ValueRepresentationNeeded.h
* Source/WebCore/Headers.cmake:
*
Source/WebCore/SaferCPPExpectations/UncountedLambdaCapturesCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/ViewTimeline.cpp:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/values/CSSValueConcepts.h:
* Source/WebCore/page/IntersectionObserver.cpp:
* Source/WebCore/rendering/RenderTreeAsText.cpp:
* Source/WebCore/rendering/style/BorderData.cpp:
* Source/WebCore/rendering/style/BorderValue.cpp:
* Source/WebCore/rendering/style/OutlineValue.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
* Source/WebCore/rendering/style/RenderStyleSetters.h:
* Source/WebCore/rendering/style/SVGRenderStyle.cpp:
* Source/WebCore/rendering/style/SVGRenderStyle.h:
* Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp:
* Source/WebCore/rendering/style/StyleAppleColorFilterData.cpp:
* Source/WebCore/rendering/style/StyleBoxData.cpp:
* Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.cpp:
* Source/WebCore/rendering/style/StyleFilterData.cpp:
* Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp:
* Source/WebCore/rendering/style/StyleFontData.cpp:
* Source/WebCore/rendering/style/StyleGridData.cpp:
* Source/WebCore/rendering/style/StyleInheritedData.cpp:
* Source/WebCore/rendering/style/StyleMarqueeData.cpp:
* Source/WebCore/rendering/style/StyleMiscNonInheritedData.cpp:
* Source/WebCore/rendering/style/StyleMultiColData.cpp:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
* Source/WebCore/rendering/style/StyleSurroundData.cpp:
* Source/WebCore/rendering/style/StyleTransformData.cpp:
* Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleExtractorConverter.h:
* Source/WebCore/style/StyleExtractorSerializer.h:
* Source/WebCore/style/StyleInterpolationWrappers.h:
* Source/WebCore/style/values/StyleValueTypes.h:
* Source/WebCore/style/values/animations/StyleAnimation.cpp:
* Source/WebCore/style/values/backgrounds/StyleBackgroundLayer.cpp:
* Source/WebCore/style/values/backgrounds/StyleBorderImage.cpp:
* Source/WebCore/style/values/color/StyleDynamicRangeLimitMix.cpp:
* Source/WebCore/style/values/color/StyleRelativeColor.h:
* Source/WebCore/style/values/grid/StyleGridPosition.cpp:
* Source/WebCore/style/values/grid/StyleGridTemplateList.cpp:
* Source/WebCore/style/values/masking/StyleMaskBorder.cpp:
* Source/WebCore/style/values/masking/StyleMaskLayer.cpp:
* Source/WebCore/style/values/motion/StyleOffsetPosition.cpp:
* Source/WebCore/style/values/motion/StyleOffsetRotate.cpp:
*
Source/WebCore/style/values/primitives/StylePrimitiveKeyword+CSSValueConversion.h:
*
Source/WebCore/style/values/primitives/StylePrimitiveKeyword+CSSValueCreation.h:
* Source/WebCore/style/values/primitives/StylePrimitiveKeyword+Logging.h: Added.
* Source/WebCore/style/values/primitives/StylePrimitiveKeyword+Serialization.h:
*
Source/WebCore/style/values/primitives/StylePrimitiveKeyword+ValueRepresentationNeeded.h:
Added.
* Source/WebCore/style/values/scroll-animations/StyleViewFunction.cpp:
* Source/WebCore/style/values/shapes/StylePathOperationWrappers.cpp:
* Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.cpp: Added.
* Source/WebCore/style/values/svg/StyleSVGGlyphOrientationHorizontal.h: Added.
* Source/WebCore/style/values/svg/StyleSVGGlyphOrientationVertical.cpp: Added.
* Source/WebCore/style/values/svg/StyleSVGGlyphOrientationVertical.h: Added.
*
Source/WebCore/style/values/transforms/functions/StyleMatrix3DTransformFunction.cpp:
*
Source/WebCore/style/values/transforms/functions/StyleMatrixTransformFunction.cpp:
*
Source/WebCore/style/values/transforms/functions/StylePerspectiveTransformFunction.cpp:
*
Source/WebCore/style/values/transforms/functions/StyleRotateTransformFunction.cpp:
*
Source/WebCore/style/values/transforms/functions/StyleScaleTransformFunction.cpp:
*
Source/WebCore/style/values/transforms/functions/StyleSkewTransformFunction.cpp:
*
Source/WebCore/style/values/transforms/functions/StyleTranslateTransformFunction.cpp:
* Source/WebCore/style/values/transitions/StyleTransition.cpp:
Canonical link: https://commits.webkit.org/301059@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
