Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab8caf13a6f05e29b440bb567e9d89e20dac8735
      
https://github.com/WebKit/WebKit/commit/ab8caf13a6f05e29b440bb567e9d89e20dac8735
  Author: Philippe Normand <[email protected]>
  Date:   2025-09-30 (Tue, 30 Sep 2025)

  Changed paths:
    M LayoutTests/webrtc/createOfferAnswer-expected.txt
    M LayoutTests/webrtc/createOfferAnswer.html
    M Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC] End-point shouldn't generate SDP offer with empty media 
msid attribute
https://bugs.webkit.org/show_bug.cgi?id=299734

Reviewed by Xabier Rodriguez-Calvar.

Until this patch the SDP offer media corresponding to recvonly transceivers 
contained an empty msid
attribute. That attribute, if present should not be empty. Now covered by a 
layout test as well.

Driving by, minor logging improvements in PeerConnectionBackend.

* LayoutTests/webrtc/createOfferAnswer-expected.txt:
* LayoutTests/webrtc/createOfferAnswer.html:
* Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::createTransceiverBackends):

Canonical link: https://commits.webkit.org/300741@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to