Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ae1b3ca256e32adcf9f232e9c4faacabe730c36
https://github.com/WebKit/WebKit/commit/1ae1b3ca256e32adcf9f232e9c4faacabe730c36
Author: Geoffrey Garen <[email protected]>
Date: 2025-10-06 (Mon, 06 Oct 2025)
Changed paths:
M Source/JavaScriptCore/heap/AbstractSlotVisitor.h
M Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/css/CSSPrimitiveValueMappings.h
M Source/WebCore/css/CSSStyleProperties.cpp
M Source/WebCore/css/CSSStyleProperties.h
M Source/WebCore/css/CSSToLengthConversionData.cpp
M Source/WebCore/css/CSSToLengthConversionData.h
M Source/WebCore/css/calc/CSSCalcTree+CalculationValue.cpp
M Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp
M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+Transform.cpp
A Source/WebCore/loader/cache/CachedImageClient.cpp
M Source/WebCore/loader/cache/CachedImageClient.h
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/rendering/AccessibilityRegionContext.cpp
M Source/WebCore/rendering/AccessibilityRegionContext.h
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilder.h
M Source/WebCore/style/StyleBuilderConverter.h
M Source/WebCore/style/StyleBuilderState.cpp
M Source/WebCore/style/StyleBuilderState.h
M Source/WebCore/style/StyleCustomPropertyRegistry.cpp
M Source/WebCore/style/values/color/StyleDynamicRangeLimitMix.cpp
M Source/WebCore/style/values/easing/StyleLinearEasingFunction.cpp
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
Address some SaferCPP "Forward declared..." issues in WebKit/
https://bugs.webkit.org/show_bug.cgi?id=299641
rdar://161444598
Reviewed by Ryosuke Niwa.
Adopted CheckedPtr for Style::BuilderState. In this case, the complaint about
forward declaration was a real issue with unproven lifetime for a shared object.
Moved some inline functions out of line to make all type definitions visible
without increasing #includes in headers. (These are not hot paths, and/or
virtual functions anyway.)
Added some #includes in autogenerated IPC encoders / decoders to make type
definitions visible.
* Source/JavaScriptCore/heap/AbstractSlotVisitor.h:
* Source/WebCore/SaferCPPExpectations/ForwardDeclCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::TypeDeducingCSSValueMapper::operator unsigned short const):
(WebCore::TypeDeducingCSSValueMapper::operator int const):
(WebCore::TypeDeducingCSSValueMapper::operator unsigned const):
(WebCore::TypeDeducingCSSValueMapper::operator float const):
(WebCore::TypeDeducingCSSValueMapper::operator double const):
* Source/WebCore/css/CSSStyleProperties.cpp:
(WebCore::StyleRuleCSSStyleProperties::parentRule const):
* Source/WebCore/css/CSSStyleProperties.h:
* Source/WebCore/css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::protectedStyleBuilderState const):
* Source/WebCore/css/CSSToLengthConversionData.h:
(WebCore::CSSToLengthConversionData::styleBuilderState const):
* Source/WebCore/css/calc/CSSCalcTree+CalculationValue.cpp:
(WebCore::CSSCalc::toCalculationValue):
* Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp:
(WebCore::CSSCalc::evaluate):
(WebCore::CSSCalc::evaluateWithoutFallback):
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
(WebCore::CSSCalc::simplify):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Filter.cpp:
(WebCore::CSSPropertyParserHelpers::parseFilterValueListOrNoneRaw):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Transform.cpp:
(WebCore::CSSPropertyParserHelpers::parseTransformRaw):
* Source/WebCore/loader/cache/CachedImageClient.cpp: Added.
(WebCore::CachedImageClient::imageFrameAvailable):
* Source/WebCore/loader/cache/CachedImageClient.h:
(WebCore::CachedImageClient::expectedType): Deleted.
(WebCore::CachedImageClient::imageChanged): Deleted.
(WebCore::CachedImageClient::canDestroyDecodedData const): Deleted.
(WebCore::CachedImageClient::imageFrameAvailable): Deleted.
(WebCore::CachedImageClient::imageVisibleInViewport const): Deleted.
(WebCore::CachedImageClient::didRemoveCachedImageClient): Deleted.
(WebCore::CachedImageClient::imageContentChanged): Deleted.
(WebCore::CachedImageClient::scheduleRenderingUpdateForImage): Deleted.
(WebCore::CachedImageClient::allowsAnimation const): Deleted.
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
* Source/WebCore/rendering/AccessibilityRegionContext.cpp:
(WebCore::AccessibilityRegionContext::takeBounds):
* Source/WebCore/rendering/AccessibilityRegionContext.h:
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::Builder):
(WebCore::Style::Builder::applyTopPriorityProperties):
(WebCore::Style::Builder::applyHighPriorityProperties):
(WebCore::Style::Builder::applyNonHighPriorityProperties):
(WebCore::Style::Builder::adjustAfterApplying):
(WebCore::Style::Builder::applyPropertiesImpl):
(WebCore::Style::Builder::applyCustomProperties):
(WebCore::Style::Builder::applyCustomProperty):
(WebCore::Style::Builder::applyCustomPropertyImpl):
(WebCore::Style::Builder::applyCascadeProperty):
(WebCore::Style::Builder::applyRollbackCascadeProperty):
(WebCore::Style::Builder::applyRollbackCascadeCustomProperty):
(WebCore::Style::Builder::applyProperty):
(WebCore::Style::Builder::resolveVariableReferences):
(WebCore::Style::Builder::resolveCustomPropertyForContainerQueries):
(WebCore::Style::Builder::resolveCustomPropertyValue):
(WebCore::Style::Builder::applyPageSizeDescriptor):
(WebCore::Style::Builder::ensureRollbackCascadeForRevert):
(WebCore::Style::Builder::ensureRollbackCascadeForRevertLayer):
* Source/WebCore/style/StyleBuilder.h:
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPositionTryFallbacks):
* Source/WebCore/style/StyleBuilderState.cpp:
* Source/WebCore/style/StyleBuilderState.h:
(WebCore::Style::BuilderState::create):
* Source/WebCore/style/StyleCustomPropertyRegistry.cpp:
(WebCore::Style::CustomPropertyRegistry::parseInitialValue):
* Source/WebCore/style/values/color/StyleDynamicRangeLimitMix.cpp:
(WebCore::Style::ToStyle<CSS::DynamicRangeLimitMixFunction>::operator):
* Source/WebCore/style/values/easing/StyleLinearEasingFunction.cpp:
(WebCore::Style::createTimingFunctionWithResolver):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Canonical link: https://commits.webkit.org/301075@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
