Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f51e778746b77dd1a3feb64cf747e8bdb8462e5c
https://github.com/WebKit/WebKit/commit/f51e778746b77dd1a3feb64cf747e8bdb8462e5c
Author: BJ Burg <[email protected]>
Date: 2025-09-29 (Mon, 29 Sep 2025)
Changed paths:
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebKit/CMakeLists.txt
A Source/WebKit/Shared/Automation/WebAutomationSessionMacros.h
M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
R Source/WebKit/UIProcess/Automation/WebAutomationSessionMacros.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.h
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in
Log Message:
-----------
[Interop] WPT test "pointerevent_click_is_a_pointerevent.html?mouse" is
failing when run via webdriver
https://bugs.webkit.org/show_bug.cgi?id=298676
Reviewed by Lily Spiniolas.
Build on the previous attempt by adding a special case for open dialogs.
WebAutomationSessionProxy::focusFrame now takes an optional frameID instead of
a frameID, and focuses the main frame if frameID is not set. The method is
now called by WebAutomationSession::switchToBrowsingContext even when frameID
is empty so that focus is explicitly returned to the main frame.
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/Shared/Automation/WebAutomationSessionMacros.h:
Renamed from Source/WebKit/UIProcess/Automation/WebAutomationSessionMacros.h.
Move this header to WebKit/Shared/ so it can be included from WebProcess code.
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::switchToBrowsingContext):
Don't try to focus frame if the page is showing a dialog. If the page
is showing a modal dialog, it won't handle any incoming messages
and the call to FocusFrame will deadlock, causing a timeout.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::focusFrame):
Rewrite this code more succinctly using ASYNC_FAIL_WITH_PREDEFINED_ERROR_IF.
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.h:
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in:
Canonical link: https://commits.webkit.org/300711@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
