Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f4cc8ce25d0fffddd31fb410aba467bf72412d51
https://github.com/WebKit/WebKit/commit/f4cc8ce25d0fffddd31fb410aba467bf72412d51
Author: Aditya Keerthi <[email protected]>
Date: 2025-10-06 (Mon, 06 Oct 2025)
Changed paths:
M Source/WebCore/html/ColorInputType.cpp
M Source/WebCore/html/ColorInputType.h
M Source/WebCore/platform/ColorChooserClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] Color pickers are presented at the wrong location
https://bugs.webkit.org/show_bug.cgi?id=300117
rdar://161903415
Reviewed by Tim Horton, Abrar Rahman Protyasha, and Lily Spiniolas.
iframe processes cannot convert to root view coordinates, resulting in the
popover being presented at the wrong location.
Fix by converting the rect in the UI process.
* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::rootFrameID const):
* Source/WebCore/html/ColorInputType.h:
* Source/WebCore/platform/ColorChooserClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showColorPicker):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::reattachColorChooser):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::(SiteIsolation, ColorInputPickerLocation)):
Canonical link: https://commits.webkit.org/301062@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
