Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2ed6bef9617d5d063f1edd7d2a8d596bab83fa98
https://github.com/WebKit/WebKit/commit/2ed6bef9617d5d063f1edd7d2a8d596bab83fa98
Author: Tim Horton <[email protected]>
Date: 2025-10-10 (Fri, 10 Oct 2025)
Changed paths:
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/loader/NetscapePlugInStreamLoader.cpp
M Source/WebCore/loader/NetscapePlugInStreamLoader.h
Log Message:
-----------
Many PDF tests time out sporadically as a result of the PDF not loading
https://bugs.webkit.org/show_bug.cgi?id=296096
rdar://156008706
Reviewed by Abrar Rahman Protyasha.
ResourceLoader has a fast path, `deliverResponseAndData`, which seems - at least
for PDFs - to be somewhat rarely encountered in practice. However, with small
test PDFs loaded from the filesystem, it is hit enough to cause reproducible
flaky test failures.
This fast path calls `didReceiveBuffer` to hand the data to the client, and
then immediately `didFinishLoading`.
Currently NetscapePlugInStreamLoader overrides ResourceLoader's
`didReceiveData`,
but not `didReceiveBuffer`, in order to slurp the data aside for the plugin.
This bug stems from this fact, and the fact that `deliverResponseAndData`
does not call `didReceiveData`, skipping the override.
Since `didReceiveBuffer` now appears to be the bottleneck for all paths,
replace NetscapePlugInStreamLoader's `didReceiveData` override with an override
of this method. Thus, the PDF plugin now intercepts the data when we arrive via
`deliverResponseAndData`, where it wouldn't before.
No new tests, covered by existing tests that were previously expected to be
flaky.
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebCore/loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::didReceiveBuffer):
(WebCore::NetscapePlugInStreamLoader::didReceiveData): Deleted.
* Source/WebCore/loader/NetscapePlugInStreamLoader.h:
Canonical link: https://commits.webkit.org/301346@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
