Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d49bc45cdcaa2538b30fce4c01a5980f381ba674
https://github.com/WebKit/WebKit/commit/d49bc45cdcaa2538b30fce4c01a5980f381ba674
Author: Zak Ridouh <[email protected]>
Date: 2025-10-15 (Wed, 15 Oct 2025)
Changed paths:
A LayoutTests/ipc/empty-svgfilterrenderer-expression-crash-expected.txt
A LayoutTests/ipc/empty-svgfilterrenderer-expression-crash.html
M Source/WebCore/svg/graphics/filters/SVGFilterRenderer.cpp
Log Message:
-----------
[GPU] [CoreIPC] Improve expression validation in WebCore::SVGFilterRenderer
https://bugs.webkit.org/show_bug.cgi?id=300468
rdar://161641790
Reviewed by Said Abou-Hallawa.
We can sometimes get into a state where we have an empty `expressions` vector
with a
non empty `effects` vector when making an SVGFilterRenderer, which should not
be the case.
This causes us to crash when trying to get the last valid expression in
`WebCore::SVGFilterRenderer::apply`.
Fix by hardening the IPC validation function.
* LayoutTests/ipc/empty-svgfilterrenderer-expression-crash-expected.txt: Added.
* LayoutTests/ipc/empty-svgfilterrenderer-expression-crash.html: Added.
* Source/WebCore/svg/graphics/filters/SVGFilterRenderer.cpp:
(WebCore::SVGFilterRenderer::apply):
(WebCore::SVGFilterRenderer::isValidSVGFilterExpression):
Canonical link: https://commits.webkit.org/301540@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes