Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 69c08ffd8fb483090d7e86b8d778d00733fdce9e
https://github.com/WebKit/WebKit/commit/69c08ffd8fb483090d7e86b8d778d00733fdce9e
Author: Joshua Hoffman <[email protected]>
Date: 2025-10-16 (Thu, 16 Oct 2025)
Changed paths:
A
LayoutTests/accessibility/contenteditable-spinbutton-uses-arrow-keys-expected.txt
A LayoutTests/accessibility/contenteditable-spinbutton-uses-arrow-keys.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Log Message:
-----------
AX: Increment/Decrement actions on spinbuttons should default to arrow key
behavior if implemented
https://bugs.webkit.org/show_bug.cgi?id=300727
rdar://161667991
Reviewed by Tyler Wilcock.
Spinbuttons (per the spec
https://www.w3.org/WAI/ARIA/apg/patterns/spinbutton/), are meant
to support up/down arrow key events. These event handlers are often responsible
for making
sure the value of these inputs move up by a particular step amount, and other
such state.
In many cases (e.g., when spinbuttons are not text inputs), we fallback to
sending these key
events when incrementing/decrementing via ATs. But, when a spinbutton is a text
input (in
the case of contenteditable, for example), we don't send simulated up/down
arrow key events
and just insert an updated value through simulated typing.
This PR changes our behavior for spinbuttons so that we always try an arrow key
event first,
and if it actually changes the value of the input, don't do anything else. This
will help
make the experience more uniform between AT and keyboard events.
Test: accessibility/contenteditable-spinbutton-uses-arrow-keys.html
*
LayoutTests/accessibility/contenteditable-spinbutton-uses-arrow-keys-expected.txt:
Added.
* LayoutTests/accessibility/contenteditable-spinbutton-uses-arrow-keys.html:
Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alterRangeValue):
Canonical link: https://commits.webkit.org/301689@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
