Branch: refs/heads/webkitglib/2.50
Home: https://github.com/WebKit/WebKit
Commit: 03e429492cd824ff4b00f253c9767bf80e886a22
https://github.com/WebKit/WebKit/commit/03e429492cd824ff4b00f253c9767bf80e886a22
Author: Chris Dumez <[email protected]>
Date: 2025-09-22 (Mon, 22 Sep 2025)
Changed paths:
M Source/WebCore/workers/service/server/SWServer.cpp
Log Message:
-----------
Cherry-pick 300315@main (79a0cf9b1bef).
https://bugs.webkit.org/show_bug.cgi?id=299260
Crash under SWServer::unregisterServiceWorkerClientInternal()
https://bugs.webkit.org/show_bug.cgi?id=299260
rdar://160643778
Reviewed by David Kilzer.
Validate the iterator before using it instead of assuming it is valid.
Based on crashes we see in the wild, it is possible for this iterator
to be invalid.
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::unregisterServiceWorkerClientInternal):
Canonical link: https://commits.webkit.org/300315@main
Canonical link: https://commits.webkit.org/298234.141@webkitglib/2.50
Commit: 26b41a5e48a07b9d897ba736f4a13a1973f726cf
https://github.com/WebKit/WebKit/commit/26b41a5e48a07b9d897ba736f4a13a1973f726cf
Author: Thomas Devoogdt <[email protected]>
Date: 2025-09-22 (Mon, 22 Sep 2025)
Changed paths:
M Source/WebCore/dom/DocumentFullscreen.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/platform/MediaStrategy.h
M Source/WebCore/rendering/RenderReplaced.cpp
Log Message:
-----------
Cherry-pick 300185@main (f0d8991bbfe3).
https://bugs.webkit.org/show_bug.cgi?id=299089
WebCore: fix compilation if ENABLE(VIDEO) is not set
https://bugs.webkit.org/show_bug.cgi?id=299089
Reviewed by Michael Catanzaro.
Source/WebCore/dom/DocumentFullscreen.cpp: In member function ‘void
WebCore::DocumentFullscreen::requestFullscreen(WTF::Ref<WebCore::Element>&&,
FullscreenCheckType,
WTF::CompletionHandler<void(WebCore::ExceptionOr<void>)>&&,
WebCore::MediaPlayerEnums::VideoFullscreenMode)’:
Source/WebCore/dom/DocumentFullscreen.cpp:156:40: error: invalid use of
incomplete type ‘class WebCore::HTMLVideoElement’
156 | CheckedPtr renderer = video->renderer();
| ^~
Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:3171:90: error:
‘VideoProjectionMetadataKind’ was not declared in this scope; did you mean
‘Inspector::Protocol::DOM::VideoProjectionMetadataKind’?
3171 | static Inspector::Protocol::DOM::VideoProjectionMetadataKind
videoProjectionMetadataKind(VideoProjectionMetadataKind kind)
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Inspector::Protocol::DOM::VideoProjectionMetadataKind
Source/WebCore/platform/MediaStrategy.h:73:13: error: no declaration
matches ‘void WebCore::MediaStrategy::nativeImageFromVideoFrame(const
WebCore::VideoFrame&,
WTF::CompletionHandler<void(std::optional<WTF::RefPtr<WebCore::NativeImage>
>&&)>&&)’
73 | inline void MediaStrategy::nativeImageFromVideoFrame(const
VideoFrame&, CompletionHandler<void(std::optional<RefPtr<NativeImage>>&&)>&&
completionHandler)
| ^~~~~~~~~~~~~
Source/WebCore/page/Page.cpp:3105:18: error: ‘class WebCore::Document’ has
no member named ‘shouldSuppressHDRDidChange’
3105 | document.shouldSuppressHDRDidChange();
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
Source/WebCore/rendering/RenderReplaced.cpp: In function ‘bool
WebCore::shouldRepaintOnSizeChange(RenderReplaced&)’:
Source/WebCore/rendering/RenderReplaced.cpp:123:88: error: ‘RenderMedia’
was not declared in this scope; did you mean ‘RenderMeter’?
123 | if (auto* renderImage = dynamicDowncast<RenderImage>(renderer);
renderImage && !is<RenderMedia>(*renderImage) &&
!renderImage->isShowingMissingOrImageError())
|
^~~~~~~~~~~
|
RenderMeter
Signed-off-by: Thomas Devoogdt <[email protected]>
Canonical link: https://commits.webkit.org/300185@main
Canonical link: https://commits.webkit.org/298234.142@webkitglib/2.50
Compare: https://github.com/WebKit/WebKit/compare/f54c99b2ae12...26b41a5e48a0
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
