Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c4ef631f4ab66e9819a0194509926a66770fab7
https://github.com/WebKit/WebKit/commit/8c4ef631f4ab66e9819a0194509926a66770fab7
Author: Jer Noble <[email protected]>
Date: 2025-10-12 (Sun, 12 Oct 2025)
Changed paths:
M Source/WebKit/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
Log Message:
-----------
CRASH in WebFullScreenManagerProxy::~WebFullScreenManagerProxy()
rdar://161686617
https://bugs.webkit.org/show_bug.cgi?id=300522
Reviewed by Simon Fraser.
Crash logs show an increase in crashes in the WebFullScreenManagerProxy
destructor,
called from the WebPageProxy destructor. It should be an impossible case to hit
the
destructor of the WebPageProxy without first having that page's close() method
called,
but that code path doesn't result in the fullscreen manager being torn down.
Close out the WebFullScreenManagerProxy when WebPageProxy is called, and for
full safety, clear out the client pointer by calling detachFromClient()
in the WebFullScreenManagerProxy destructor.
Additionally, existing tests discovered places in WKFullScreenWindowController
where
a RefPtr was used un-guarded, causing crashes during testing. These have been
turned
into guarded checks.
Canonical link: https://commits.webkit.org/301388@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
