Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5ee4e2811ebd90d4c026a30aca92c946bfeb502c
https://github.com/WebKit/WebKit/commit/5ee4e2811ebd90d4c026a30aca92c946bfeb502c
Author: Chris Dumez <[email protected]>
Date: 2025-10-11 (Sat, 11 Oct 2025)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/html/HTMLCollection.h
M Source/WebCore/html/HTMLCollection.idl
M Source/WebCore/html/HTMLCollectionInlines.h
Log Message:
-----------
Drop Custom toJS() / toJSNewlyCreated() functions for HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=300467
Reviewed by Ryosuke Niwa.
Drop Custom toJS() / toJSNewlyCreated() functions for HTMLCollection as
the bindings generator knows how to generate them now.
Note that unlike the manual code, the generated code doesn't deal with
HTMLAllCollection. The reason for this is that HTMLAllCollection does
NOT inherit HTMLCollection in Web IDL. However, it does in our C++
implementation. The good news is that HTMLAllCollection is deprecated
and only returned in one place: `document.all` where we can return
a HTMLAllCollection directly instead of an HTMLCollection, so that
`toJS(const HTMLCollection&)` does not get called.
This tested as performance neutral on Speedometer.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::all):
* Source/WebCore/dom/Document.h:
* Source/WebCore/html/HTMLCollection.h:
(WebCore::HTMLCollection::type const):
* Source/WebCore/html/HTMLCollection.idl:
* Source/WebCore/html/HTMLCollectionInlines.h:
(WebCore::HTMLCollection::type const): Deleted.
Canonical link: https://commits.webkit.org/301350@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
