Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: eadd64122b83781dc378218c5a073f9935bec2b9
https://github.com/WebKit/WebKit/commit/eadd64122b83781dc378218c5a073f9935bec2b9
Author: Nipun Shukla <[email protected]>
Date: 2025-10-10 (Fri, 10 Oct 2025)
Changed paths:
A LayoutTests/webaudio/audioworklet-does-not-leak-expected.txt
A LayoutTests/webaudio/audioworklet-does-not-leak.html
A LayoutTests/webaudio/resources/audioworklet-leak-test-frame.html
M Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.cpp
M Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
Log Message:
-----------
[World Leaks] Investigate leaks in
LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/
https://bugs.webkit.org/show_bug.cgi?id=299312
rdar://161118548
Reviewed by Chris Dumez.
AudioWorkletMessagingProxy holds a strong const Ref<Document>. Removing this
reference and
using a ScriptExecutionContextIdentifier to post tasks when necessary fixes
approximately
30 leaky tests.
Test: webaudio/audioworklet-does-not-leak.html
* LayoutTests/webaudio/audioworklet-does-not-leak-expected.txt: Added.
* LayoutTests/webaudio/audioworklet-does-not-leak.html: Added.
* LayoutTests/webaudio/resources/audioworklet-leak-test-frame.html: Added.
* Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.cpp:
(WebCore::AudioWorkletMessagingProxy::AudioWorkletMessagingProxy):
(WebCore::AudioWorkletMessagingProxy::createRTCDataChannelRemoteHandlerConnection):
(WebCore::AudioWorkletMessagingProxy::loaderContextIdentifier const):
(WebCore::AudioWorkletMessagingProxy::postTaskToLoader):
(WebCore::AudioWorkletMessagingProxy::postTaskToAudioWorklet):
* Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::messagePortDisentangled):
Canonical link: https://commits.webkit.org/301328@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
