Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 235ac443b41f7d63d70ad42f83f58da00d75b063
      
https://github.com/WebKit/WebKit/commit/235ac443b41f7d63d70ad42f83f58da00d75b063
  Author: Basuke Suzuki <[email protected]>
  Date:   2025-10-15 (Wed, 15 Oct 2025)

  Changed paths:
    M Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py

  Log Message:
  -----------
  [MiniBrowser] Fix parameter passing to WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=300809
rdar://162689631

Reviewed by Sihui Liu.

We can pass debugging flag like this before:

$ run-minibrowser -WebCoreLogging Layout

But it regressed at 299873@main. This is because we need to pass as is to WKTR.

At 299873@main, intension was to allow this kind of order:

$ run-minibrowser --site-isolation URL
$ run-minibrowser URL --site-isolation

To make this happen, we need to add `--url` before URL to WKTR. For known 
arguments,
this is perfect. But this doesn't work for the unknown arguments for python 
script.

So to support this kind of arguments, we cannot write like this:

$ run-minibrowser -WebCoreLogging Layout URL

URL must come before debug flags.

* Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py:
(main):

Canonical link: https://commits.webkit.org/301582@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to