Title: [113485] trunk/LayoutTests
- Revision
- 113485
- Author
- [email protected]
- Date
- 2012-04-06 12:58:53 -0700 (Fri, 06 Apr 2012)
Log Message
IndexedDB: Race condition in layout test logging from window and worker
https://bugs.webkit.org/show_bug.cgi?id=83378
The sequencing of logging directly from window vs. logging via posted events
from a worker is racy, making this test flake when run under Chromium. Removed
the sensitive logging on the window side; the test logic is unaffected as the
blocked/success event sequence would not be present if the window handler was
not run.
Reviewed by Tony Chang.
* storage/indexeddb/dont-commit-on-blocked-expected.txt:
* storage/indexeddb/dont-commit-on-blocked.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (113484 => 113485)
--- trunk/LayoutTests/ChangeLog 2012-04-06 19:54:28 UTC (rev 113484)
+++ trunk/LayoutTests/ChangeLog 2012-04-06 19:58:53 UTC (rev 113485)
@@ -1,3 +1,19 @@
+2012-04-06 Joshua Bell <[email protected]>
+
+ IndexedDB: Race condition in layout test logging from window and worker
+ https://bugs.webkit.org/show_bug.cgi?id=83378
+
+ The sequencing of logging directly from window vs. logging via posted events
+ from a worker is racy, making this test flake when run under Chromium. Removed
+ the sensitive logging on the window side; the test logic is unaffected as the
+ blocked/success event sequence would not be present if the window handler was
+ not run.
+
+ Reviewed by Tony Chang.
+
+ * storage/indexeddb/dont-commit-on-blocked-expected.txt:
+ * storage/indexeddb/dont-commit-on-blocked.html:
+
2012-04-06 Florin Malita <[email protected]>
[chromium] Rebaseline svg/clip-path/deep-nested-clip-in-mask* expectations
Modified: trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked-expected.txt (113484 => 113485)
--- trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked-expected.txt 2012-04-06 19:54:28 UTC (rev 113484)
+++ trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked-expected.txt 2012-04-06 19:58:53 UTC (rev 113485)
@@ -25,10 +25,6 @@
[Worker] db = request.result
[Worker] state = 'setversion'
[Worker] request = db.setVersion(2)
-
-onVersionChange():
-closing connection
-db.close()
[Worker] request._onblocked_ = onSetVersionBlocked
[Worker] request._onsuccess_ = onSetVersionSuccess
[Worker] spinning for 100ms to let events be queued but prevent dispatch
Modified: trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked.html (113484 => 113485)
--- trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked.html 2012-04-06 19:54:28 UTC (rev 113484)
+++ trunk/LayoutTests/storage/indexeddb/dont-commit-on-blocked.html 2012-04-06 19:58:53 UTC (rev 113485)
@@ -51,10 +51,8 @@
function onVersionChange(e)
{
- debug("");
- debug("onVersionChange():");
- debug("closing connection");
- evalAndLog("db.close()");
+ // Timing of logging from worker vs. this event is racy, so do not log here.
+ db.close();
}
test();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
