Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fc6aac253ffd80a9d112ecbe27b78682ebd03c62
https://github.com/WebKit/WebKit/commit/fc6aac253ffd80a9d112ecbe27b78682ebd03c62
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-10-05 (Sun, 05 Oct 2025)
Changed paths:
M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm
M Tools/TestWebKitAPI/cocoa/TestContextMenuDriver.mm
Log Message:
-----------
TestContextMenuDriver should adopt
-clickDriver:shouldBegin:(void(^)(_UIClickInteractionShouldBeginResult)) SPI
https://bugs.webkit.org/show_bug.cgi?id=300186
rdar://161975075
Reviewed by Richard Robinson.
TestContextMenuDriver currently uses _UIClickInteractionDriverDelegate
IPI, which is the shouldBegin: variant accepting a boolean argument
completion handler. This causes issues with module verification since
the signature does not exist in SDKs.
This patch does a few things:
1. Moves the _UIClickInteractionDriverDelegate-adjacent SPI declarations
to !USE(APPLE_INTERNAL_SDK) section, given internal SDK builds can
pick up the declarations through _UIClickInteractionDriving.h.
2. Remove the now unnecessary UIDropInteractionDelegate_Private SPI
declaration.
3. Adopt shouldBegin: accepting a _UIClickInteractionShouldBeginResult
argument completion handler. Note that TestContextMenuDriver API need
not change.
* Tools/TestRunnerShared/spi/UIKitSPIForTesting.h:
* Tools/TestWebKitAPI/cocoa/TestContextMenuDriver.mm:
(-[TestContextMenuDriver begin:]):
Canonical link: https://commits.webkit.org/301019@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
