Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 70ff75704e53e2947b598287b894ae6a6b3b1caa
https://github.com/WebKit/WebKit/commit/70ff75704e53e2947b598287b894ae6a6b3b1caa
Author: Alexey Proskuryakov <[email protected]>
Date: 2025-10-13 (Mon, 13 Oct 2025)
Changed paths:
M Tools/Scripts/webkitpy/common/system/filesystem_mock.py
M
Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
Log Message:
-----------
run-webkit-tests doesn't properly enable skipped tests when passed on command
line with LayoutTests in the path
https://bugs.webkit.org/show_bug.cgi?id=300464
rdar://162335032
Reviewed by Jonathan Bedard.
run-webkit-tests has weird logic for finding tests specified on command line.
All of these
find the test regardless of current working directory:
- fast/events/keydown-numpad-keys.html
- LayoutTests/fast/events/keydown-numpad-keys.html
- ~/LayoutTests/fast/events/keydown-numpad-keys.html
Some of this may not be important to preserve, but this fix focuses on making
it work consistently,
namely, just making sure that the test isn't just found, but is also force
enabled if skipped.
run-webkit-tests also has its own globbing used separately from shell globbing.
When run-webkit-tests expands the pattern, that currently doesn't force enable
the tests.
In other words, `run-webkit-tests fast/events/*` may run different tests
depending on
current directory. This is arguably bad, but harder to change, because many
tests rely on
this quirk.
* Tools/Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.glob): Normalize glob string before matching, so that tests can
use relative
paths.
* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder_legacy.py:
(LayoutTestFinder.find_tests_for_specified_files): Added method to find only
explicitly
specified individual test files.
* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Use find_tests_for_specified_files() for skip-override logic
instead of
directly checking args.
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_ews_corner_case_skipped_test_with_layouttests_prefix): Added.
(RunTest.test_ews_corner_case_skipped_test_with_relative_path): Added.
Canonical link: https://commits.webkit.org/301409@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
