Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f406d3ac22e4add3a9f4b67c3d6fdba8a635b8d9
      
https://github.com/WebKit/WebKit/commit/f406d3ac22e4add3a9f4b67c3d6fdba8a635b8d9
  Author: Chris Dumez <[email protected]>
  Date:   2025-10-05 (Sun, 05 Oct 2025)

  Changed paths:
    M Source/WebCore/Modules/webxr/XRCompositionLayer.idl
    A Source/WebCore/Modules/webxr/XRCubeLayer.cpp
    M Source/WebCore/Modules/webxr/XRCubeLayer.h
    M Source/WebCore/Modules/webxr/XRCubeLayer.idl
    A Source/WebCore/Modules/webxr/XRCylinderLayer.cpp
    M Source/WebCore/Modules/webxr/XRCylinderLayer.h
    M Source/WebCore/Modules/webxr/XRCylinderLayer.idl
    A Source/WebCore/Modules/webxr/XREquirectLayer.cpp
    M Source/WebCore/Modules/webxr/XREquirectLayer.h
    M Source/WebCore/Modules/webxr/XREquirectLayer.idl
    A Source/WebCore/Modules/webxr/XRQuadLayer.cpp
    M Source/WebCore/Modules/webxr/XRQuadLayer.h
    M Source/WebCore/Modules/webxr/XRQuadLayer.idl
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Several WebXRLayer subclasses are pure virtual
https://bugs.webkit.org/show_bug.cgi?id=300206

Reviewed by Mike Wyrzykowski.

Several WebXRLayer subclasses are pure virtual and it is causing issues
with the generated bindings (https://github.com/WebKit/WebKit/pull/51823).

Add the missing implementation to avoid linking issues and drop the IDL
extended attributes that were added to work around it in 301038@main.

* Source/WebCore/Modules/webxr/XRCompositionLayer.idl:
* Source/WebCore/Modules/webxr/XRCubeLayer.cpp: Copied from 
Source/WebCore/Modules/webxr/XRCubeLayer.h.
* Source/WebCore/Modules/webxr/XRCubeLayer.h:
* Source/WebCore/Modules/webxr/XRCubeLayer.idl:
* Source/WebCore/Modules/webxr/XRCylinderLayer.cpp: Copied from 
Source/WebCore/Modules/webxr/XRCubeLayer.h.
* Source/WebCore/Modules/webxr/XRCylinderLayer.h:
* Source/WebCore/Modules/webxr/XRCylinderLayer.idl:
* Source/WebCore/Modules/webxr/XREquirectLayer.cpp: Copied from 
Source/WebCore/Modules/webxr/XRCubeLayer.h.
* Source/WebCore/Modules/webxr/XREquirectLayer.h:
* Source/WebCore/Modules/webxr/XREquirectLayer.idl:
* Source/WebCore/Modules/webxr/XRQuadLayer.cpp: Copied from 
Source/WebCore/Modules/webxr/XRCubeLayer.h.
* Source/WebCore/Modules/webxr/XRQuadLayer.h:
* Source/WebCore/Modules/webxr/XRQuadLayer.idl:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/301041@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to