Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 48e1564f70cad53abf47c70ee56c1d08088bd9cf
      
https://github.com/WebKit/WebKit/commit/48e1564f70cad53abf47c70ee56c1d08088bd9cf
  Author: Basuke Suzuki <[email protected]>
  Date:   2025-10-16 (Thu, 16 Oct 2025)

  Changed paths:
    M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm

  Log Message:
  -----------
  [APITest] `browser.test.assertRejects` returns Promise so it should be 
treated as such.
https://bugs.webkit.org/show_bug.cgi?id=300953
rdar://162803291

Reviewed by Timothy Hatcher.

There are some tests that runs `browser.test.assertRejects()` as usual 
function. They should
be `await`. Also there is one mis-usage of the function (passing function not 
Promise).

* 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, GetSessionRules)):
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, GetDynamicRules)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIScripting.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIScripting, 
ErrorsRegisteredContentScript)):
(TestWebKitAPI::TEST(WKWebExtensionAPIScripting, UnregisterContentScripts)):

Canonical link: https://commits.webkit.org/301690@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to