Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 32c25bb712d4823ffdc1c4de1f56c0e803809136
https://github.com/WebKit/WebKit/commit/32c25bb712d4823ffdc1c4de1f56c0e803809136
Author: Ryan Haddad <[email protected]>
Date: 2025-10-15 (Wed, 15 Oct 2025)
Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/popen.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
Log Message:
-----------
webkitscmpy.local.git.Git.branch shouldn't call git-status
rdar://158438687
https://bugs.webkit.org/show_bug.cgi?id=297485
Reviewed by Jonathan Bedard.
We are running `git status` in this case in order to determine whether or not
the checkout
is in a detached head state. As Sam pointed out, running `git symbolic-ref -q
HEAD` accomplishes
the same goal and can run much faster.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/popen.py:
(PopenBase.__init__): Add support for handling subprocess.DEVNULL.
(PopenBase.poll): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.branch): Switch to `git symbolic-ref -q HEAD`, which exits with 1 if
detached
and 0 if not detached.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git): Add new mock.
Canonical link: https://commits.webkit.org/301587@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
