Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 442f70039632a62ac7f66cd912493a1c7c798d90
https://github.com/WebKit/WebKit/commit/442f70039632a62ac7f66cd912493a1c7c798d90
Author: Brianna Fan <[email protected]>
Date: 2025-09-23 (Tue, 23 Sep 2025)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
Safer CPP EWS shouldn't blame PR authors when the ToT build is broken
rdar://158725634
https://bugs.webkit.org/show_bug.cgi?id=297628
Reviewed by Aakash Jain.
We should follow the convention set by other build queues in retrying the
build if there is a build failure. Then, we blame the PR if the build failure
is truly caused by it. If not, we requeue the build for a retry.
* Tools/CISupport/ews-build/steps.py:
(ScanBuild):
- Move the logic that adds steps to addFollowUpSteps. This allows us to
overwrite it in ScanBuildWithoutChange.
(ScanBuild.__init__):
(ScanBuild.run):
(ScanBuild.addFollowUpSteps):
(ScanBuild.uploadLogsSteps):
(ScanBuild.getResultSummary):
(ScanBuildWithoutChange.__init__):
- Add analyze_safercpp_results. If the first build succeeds, this is set to
True.
If the first build fails, this is set to False. This means the second
build is only to verify if there's a build failure due to the PR and we
don't want to analyze any results.
(ScanBuildWithoutChange):
(ScanBuildWithoutChange.addFollowUpSteps):
- Either add steps to analyze results, or end the build with a failure or
retry
depending on the results of the build.
(ScanBuildWithoutChange.send_email_for_unexpected_build_failure):
- Similar to CompileWebKitWithoutChange, send email upon build failure.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/300409@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
