Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c536d0bbed8a18568c19a4ee4354c3ebd5a86799
      
https://github.com/WebKit/WebKit/commit/c536d0bbed8a18568c19a4ee4354c3ebd5a86799
  Author: Wenson Hsieh <[email protected]>
  Date:   2025-10-01 (Wed, 01 Oct 2025)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKUIScrollEdgeEffect.h
    M Source/WebKit/UIProcess/ios/WKUIScrollEdgeEffect.mm
    M Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm

  Log Message:
  -----------
  [Liquid Glass] [iOS] Make it possible to KVO the `isHidden` property on 
`webView.scrollView.topEdgeEffect`
https://bugs.webkit.org/show_bug.cgi?id=299954
rdar://161734906

Reviewed by Aditya Keerthi.

Make it possible to add KVO on `WKScrollView`'s scroll edge effects, to observe 
the `isHidden`
property. This allows clients (namely, Safari) to observe when top or bottom 
soft scroll pockets are
being suppressed due to the presence of a fixed or sticky element near the 
edges of the viewport.

Test: Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm

* Source/WebKit/UIProcess/ios/WKUIScrollEdgeEffect.h:
* Source/WebKit/UIProcess/ios/WKUIScrollEdgeEffect.mm:
(-[WKUIScrollEdgeEffect isHidden]):
(-[WKUIScrollEdgeEffect _setHidden:fromSource:]):

Add a `isHidden` property that wraps the real `UIScrollEdgeEffect`'s `isHidden` 
property; whenever
this changes, call `(will|did)ChangeValueForKey:`.

* Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
(-[ScrollEdgeEffectIsHiddenObserver initWithScrollEdgeEffect:callback:]):
(-[ScrollEdgeEffectIsHiddenObserver dealloc]):
(-[ScrollEdgeEffectIsHiddenObserver 
observeValueForKeyPath:ofObject:change:context:]):

Add a helper object to observe changes to `-[UIScrollEdgeEffect isHidden]`.

(TestWebKitAPI::TEST(WKScrollViewTests, TopScrollEdgeEffectIsHiddenKVO)):

Canonical link: https://commits.webkit.org/300833@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to