Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1a60c58e0682f10b64c0d640938adeaffdce4b4f
https://github.com/WebKit/WebKit/commit/1a60c58e0682f10b64c0d640938adeaffdce4b4f
Author: Frédéric Wang <[email protected]>
Date: 2025-10-09 (Thu, 09 Oct 2025)
Changed paths:
M
Source/JavaScriptCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M
Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py
M
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/definitions-with-mac-platform.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-exposed-as-other-name.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result
M
Source/JavaScriptCore/inspector/scripts/tests/expected/type-with-open-parameters.json-result
M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
Log Message:
-----------
Fix UncountedCallArgs errors for code generated by
generate-inspector-protocol-bindings.py
https://bugs.webkit.org/show_bug.cgi?id=300309
Reviewed by Devin Rousso.
m_result is a RefPtr member but per [1] we need either it to be a smart
pointer on the stack or to be a const. The latter is not possible
because of [2].
[1]
https://github.com/WebKit/WebKit/wiki/Safer-CPP-Guidelines#mark-data-members-that-are-smart-pointers-as-const-if-they-never-get-reassigned
[2]
https://searchfox.org/wubkat/rev/dd05eb230972a07f0240b959e6e22ca685ef3445/Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py#224
*
Source/JavaScriptCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
Update expectations.
*
Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
Store smart pointer for m_result on the stack.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
Regenerate expectation.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/definitions-with-mac-platform.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/domain-exposed-as-other-name.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/fail-on-command-targetTypes-value.json-error:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/fail-on-domain-targetTypes-value.json-error:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/fail-on-event-targetTypes-value.json-error:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
Ditto.
*
Source/JavaScriptCore/inspector/scripts/tests/expected/type-with-open-parameters.json-result:
Ditto.
* Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
Update expectations.
Canonical link: https://commits.webkit.org/301256@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
