Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 58e3c06728fffa90bec0068fdbb6d03f16e3da1d
https://github.com/WebKit/WebKit/commit/58e3c06728fffa90bec0068fdbb6d03f16e3da1d
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2025-10-18 (Sat, 18 Oct 2025)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm
A Tools/TestWebKitAPI/Tests/WebKitCocoa/textInput.pdf
Log Message:
-----------
REGRESSION(297117@main): Active annotation hover effect sticks around after
moving pointer away
https://bugs.webkit.org/show_bug.cgi?id=301017
rdar://162799398
Reviewed by Wenson Hsieh.
In 297117@main, we started using protectedTrackedAnnotation() from the
annotation tracking state, rather than retaining a pointer to this
tracked annotation and reading from that.
This is OK usually, but AnnotationTrackingState::finishAnnotationTracking
clears out the tracked annotation, so later, we incorrectly specify
repaint requirements for the previously tracked annotation.
We fix this bug by holding on to the previously tracked annotation
rather than keying off of annotation tracking state, which
understandably does not guarantee the right state when in its "finish"
path.
Test: TestWebKitAPI.UnifiedPDF.TextAnnotationHoverEffect
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::finishTrackingAnnotation):
(WebKit::AnnotationTrackingState::finishAnnotationTracking):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/UnifiedPDFTests.mm:
(TestWebKitAPI::UNIFIED_PDF_TEST):
Canonical link: https://commits.webkit.org/301780@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
