Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 48810d0c2a9f672262b51ad68c998423cb2a661d
https://github.com/WebKit/WebKit/commit/48810d0c2a9f672262b51ad68c998423cb2a661d
Author: Claudio Saavedra <[email protected]>
Date: 2025-10-21 (Tue, 21 Oct 2025)
Changed paths:
M Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm
M Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm
M Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeTask.mm
Log Message:
-----------
Address post-landing review comments on recent safer CPP fixes
https://bugs.webkit.org/show_bug.cgi?id=301182
Reviewed by Darin Adler.
Darin suggested that instead of ObjC++ methods we should use
static C++ functions for protected getters, where it makes
sense. Fix a few of instances from my recent commits to follow this.
* Source/WebKit/UIProcess/API/C/mac/WKPagePrivateMac.mm:
(protectedPage):
(-[WKObservablePageState initWithPage:]):
(-[WKObservablePageState isLoading]):
(-[WKObservablePageState title]):
(-[WKObservablePageState URL]):
(-[WKObservablePageState hasOnlySecureContent]):
(-[WKObservablePageState _webProcessIsResponsive]):
(-[WKObservablePageState estimatedProgress]):
(-[WKObservablePageState unreachableURL]):
(-[WKObservablePageState serverTrust]):
(-[WKObservablePageState _protectedPage]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm:
(protectedFrameInfo):
(-[WKFrameInfo dealloc]):
(-[WKFrameInfo webView]):
(-[WKFrameInfo _handle]):
(-[WKFrameInfo _parentFrameHandle]):
(-[WKFrameInfo _title]):
(-[WKFrameInfo _protectedFrameInfo]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeTask.mm:
(protectedURLSchemeTask):
(-[WKURLSchemeTaskImpl request]):
(-[WKURLSchemeTaskImpl _requestOnlyIfCached]):
(-[WKURLSchemeTaskImpl _willPerformRedirection:newRequest:completionHandler:]):
(-[WKURLSchemeTaskImpl didReceiveResponse:]):
(-[WKURLSchemeTaskImpl didReceiveData:]):
(-[WKURLSchemeTaskImpl didFinish]):
(-[WKURLSchemeTaskImpl didFailWithError:]):
(-[WKURLSchemeTaskImpl _didPerformRedirection:newRequest:]):
(-[WKURLSchemeTaskImpl _protectedURLSchemeTask]): Deleted.
Canonical link: https://commits.webkit.org/301871@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
