Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56f36c24abfdf7d5b1be8dc65698c77064fe34a6
https://github.com/WebKit/WebKit/commit/56f36c24abfdf7d5b1be8dc65698c77064fe34a6
Author: Nipun Shukla <[email protected]>
Date: 2025-10-22 (Wed, 22 Oct 2025)
Changed paths:
A LayoutTests/animations/animation-timeline-does-not-leak-expected.txt
A LayoutTests/animations/animation-timeline-does-not-leak.html
A LayoutTests/animations/resources/animation-timeline-leak-test.html
M Source/WebCore/animation/WebAnimation.cpp
Log Message:
-----------
[World Leaks] Fix leaks in
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/
https://bugs.webkit.org/show_bug.cgi?id=300333
rdar://162132950
Reviewed by Antoine Quint.
Change WebAnimation::stop() such that upon stopping a WebAnimation we also
remove the effect
by calling setEffectInternal(nullptr). This fixes approximately 10 leaky tests.
Test: animations/animation-timeline-does-not-leak.html
* LayoutTests/animations/animation-timeline-does-not-leak-expected.txt: Added.
* LayoutTests/animations/animation-timeline-does-not-leak.html: Added.
* LayoutTests/animations/resources/animation-timeline-leak-test.html: Added.
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::stop):
Canonical link: https://commits.webkit.org/301956@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
