Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 93de15db619ee087390119b3c9c246237ea22f56
https://github.com/WebKit/WebKit/commit/93de15db619ee087390119b3c9c246237ea22f56
Author: Jer Noble <[email protected]>
Date: 2025-10-25 (Sat, 25 Oct 2025)
Changed paths:
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebKit/UIProcess/Cocoa/_WKCaptionStyleMenuController.h
A Source/WebKit/UIProcess/ios/_WKCaptionStyleMenuControllerIOS.mm
M Source/WebKit/UIProcess/mac/_WKCaptionStyleMenuControllerMac.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/CaptionPreferencesTests.mm
Log Message:
-----------
pen[iOS] Add a pop-up menu for selecting caption style profiles
https://bugs.webkit.org/show_bug.cgi?id=301376
rdar://problem/163297495
Reviewed by Eric Carlson.
In 301952@main, a pop-up menu was added for macOS; add a similar pop-up menu
for iOS that allows the user to pick between their preferred subtitle styles.
Test: Tools/TestWebKitAPI/Tests/WebCore/cocoa/CaptionPreferencesTests.mm
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebKit/UIProcess/_WKCaptionStyleMenuControllerIOS.mm: Added.
(-[WKCaptionStyleMenuController init]):
(-[WKCaptionStyleMenuController rebuildMenu]):
(-[WKCaptionStyleMenuController isAncestorOf:]):
(-[WKCaptionStyleMenuController captionStyleMenu]):
(-[WKCaptionStyleMenuController contextMenuInteraction]):
(-[WKCaptionStyleMenuController profileActionSelected:]):
(-[WKCaptionStyleMenuController systemCaptionStyleSettingsActionSelected:]):
(-[WKCaptionStyleMenuController notifyMenuWillOpen]):
(-[WKCaptionStyleMenuController notifyMenuDidClose]):
(-[WKCaptionStyleMenuController
contextMenuInteraction:configurationForMenuAtLocation:]):
(-[WKCaptionStyleMenuController
contextMenuInteraction:willDisplayMenuForConfiguration:animator:]):
(-[WKCaptionStyleMenuController
contextMenuInteraction:willEndForConfiguration:animator:]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/CaptionPreferencesTests.mm:
(-[CaptionPreferenceTestMenuControllerDelegate captionStyleMenuWillOpen:]):
(-[CaptionPreferenceTestMenuControllerDelegate captionStyleMenuDidClose:]):
(TestWebKitAPI::CaptionPreferenceTests::ensureController):
(TestWebKitAPI::CaptionPreferenceTests::ensureMenu):
(TestWebKitAPI::CaptionPreferenceTests::showMenuAndThen):
(TestWebKitAPI::CaptionPreferenceTests::runAndWaitForCaptionStyleMenuWillOpenCalled):
(TestWebKitAPI::CaptionPreferenceTests::runAndWaitForCaptionStyleMenuDidCloseCalled):
(TestWebKitAPI::CaptionPreferenceTests::selectProfileAtIndex):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, ShimTest)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, FontFace)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, FontSize)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, Colors)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, BorderRadius)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, TextEdge)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, CaptionStyleMenu)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, CaptionStyleMenuHighlight)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, CaptionStyleMenuSelect)):
(TestWebKitAPI::TEST_F(CaptionPreferenceTests, CaptionStyleMenuDelegate)):
(TestWebKitAPI::TEST(CaptionPreferenceTests, ShimTest)): Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, FontFace)): Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, FontSize)): Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, Colors)): Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, BorderRadius)): Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, TextEdge)): Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, CaptionStyleMenu)): Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, CaptionStyleMenuHighlight)):
Deleted.
(TestWebKitAPI::TEST(CaptionPreferenceTests, CaptionStyleMenuSelect)): Deleted.
Canonical link: https://commits.webkit.org/302143@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
