Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3a081cf92b798cf55b7db87e407d44b6efd004c9
https://github.com/WebKit/WebKit/commit/3a081cf92b798cf55b7db87e407d44b6efd004c9
Author: Wenson Hsieh <[email protected]>
Date: 2025-10-28 (Tue, 28 Oct 2025)
Changed paths:
M Source/WebCore/page/text-extraction/TextExtraction.cpp
M Source/WebCore/page/text-extraction/TextExtraction.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/TextExtractionTests.mm
Log Message:
-----------
[AutoFill Debugging] Improve debug descriptions for click interactions that
only use a location
https://bugs.webkit.org/show_bug.cgi?id=301584
rdar://163577331
Reviewed by Patrick Angle and Abrar Rahman Protyasha.
Augment descriptions for click interactions that only contain a `location`
parameter. Currently, the
descriptions just say `Click at (x, y)`; after these changes, it will say
something like:
> `Click at (x, y) on child node of button labeled `“Click me”, with text
> “Hello”`
...which clearly explains which element is about to be activated.
Test: added to TextExtractionTests.InteractionDebugDescription
* Source/WebCore/page/text-extraction/TextExtraction.cpp:
(WebCore::TextExtraction::findNodeAtRootViewLocation):
(WebCore::TextExtraction::dispatchSimulatedClick):
(WebCore::TextExtraction::textDescription):
Pull the main bulk of this logic out into a separate static helper which
receives a `Node`, so that
we can reuse it for this new codepath that produces a text description for the
hit-tested node in
root view coordinates.
(WebCore::TextExtraction::interactionDescription):
* Source/WebCore/page/text-extraction/TextExtraction.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::describeTextExtractionInteraction):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextExtractionTests.mm:
(TestWebKitAPI::TEST(TextExtractionTests, InteractionDebugDescription)):
Canonical link: https://commits.webkit.org/302257@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
