Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 030d681521d7bbe482dad397f2265487817c275f
https://github.com/WebKit/WebKit/commit/030d681521d7bbe482dad397f2265487817c275f
Author: Carlos Garcia Campos <[email protected]>
Date: 2025-10-23 (Thu, 23 Oct 2025)
Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
R Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/platform/xr/PlatformXR.h
Log Message:
-----------
[WebXR] Unify WebXROpaqueFramebuffer and WebXROpaqueFramebufferCocoa
https://bugs.webkit.org/show_bug.cgi?id=297900
Reviewed by Dan Glastonbury.
This consolidates both WebXROpaqueFramebuffer and
WebXROpaqueFrameBufferCocoa together, as now that GTK and WPE implement
WebXR using the same architecture as Cocoa, their code is nearly
identical and reunification should prevent breakages.
No new tests needed, covered by existing tests.
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::makeExternalImageSource):
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
(WebCore::WebXROpaqueFramebuffer::resolveMSAAFramebuffer):
(WebCore::WebXROpaqueFramebuffer::supportsDynamicViewportScaling const):
(WebCore::WebXROpaqueFramebuffer::drawViewport const):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
(WebCore::WebXROpaqueFramebuffer::reusableDisplayAttachments const):
(WebCore::WebXROpaqueFramebuffer::bindCompositorTexturesForDisplay):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebufferCocoa.cpp: Removed.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/xr/PlatformXR.h:
(PlatformXR::FrameData::ExternalTexture::isNull const):
Canonical link: https://commits.webkit.org/302027@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
