Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f647097804305b55bfdced7ba9b590202fdc16cc
https://github.com/WebKit/WebKit/commit/f647097804305b55bfdced7ba9b590202fdc16cc
Author: Zak Ridouh <[email protected]>
Date: 2025-10-22 (Wed, 22 Oct 2025)
Changed paths:
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-expected.txt
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text-expected.txt
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text.html
A
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow.html
M Source/WebCore/rendering/RenderBlock.cpp
Log Message:
-----------
[Layout] Fix crash in WebCore::RenderGrid::gridAreaRangeForOutOfFlow
https://bugs.webkit.org/show_bug.cgi?id=300354
rdar://161639703
Reviewed by Alan Baradlay.
Fix a crash in WebCore::RenderGrid::gridAreaRangeForOutOfFlow where we haven't
completed
in-flow placement and grid sizing yet, and so our positions vector doesn't have
valid values.
This aligns us closer with the spec, where only in flow children are
eligible for margin collapsing.
The root cause of this crash is we're attempting to do margin collapsing with
an out of flow child, but
we can only do this for in flow children.
[1] <https://drafts.csswg.org/css2/#collapsing-margins>
*
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-expected.txt:
Added.
*
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text-expected.txt:
Added.
*
LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow-no-text.html:
Added.
* LayoutTests/fast/css-grid-layout/grid-crash-area-range-for-out-of-flow.html:
Added.
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelfCollapsingBlock const):
Canonical link: https://commits.webkit.org/301976@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
