Title: [113556] trunk/Source/WebKit/mac
Revision
113556
Author
[email protected]
Date
2012-04-08 22:25:55 -0700 (Sun, 08 Apr 2012)

Log Message

[mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=83453

Reviewed by Sam Weinig.

* WebView/WebView.mm:
(-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
no custom scale factor, this method was setting the Page scale factor to 0, and that value
was used by canvas. Changed it to correctly set the Page scale factor back to the device
scale factor.

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (113555 => 113556)


--- trunk/Source/WebKit/mac/ChangeLog	2012-04-09 04:59:28 UTC (rev 113555)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-04-09 05:25:55 UTC (rev 113556)
@@ -1,3 +1,16 @@
+2012-04-08  Dan Bernstein  <[email protected]>
+
+        [mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
+        https://bugs.webkit.org/show_bug.cgi?id=83453
+
+        Reviewed by Sam Weinig.
+
+        * WebView/WebView.mm:
+        (-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
+        no custom scale factor, this method was setting the Page scale factor to 0, and that value
+        was used by canvas. Changed it to correctly set the Page scale factor back to the device
+        scale factor.
+
 2012-04-06  Alexey Proskuryakov  <[email protected]>
 
         [Mac] Adopt a different method of telling AppKit when inline input isn't supported

Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (113555 => 113556)


--- trunk/Source/WebKit/mac/WebView/WebView.mm	2012-04-09 04:59:28 UTC (rev 113555)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2012-04-09 05:25:55 UTC (rev 113556)
@@ -2888,7 +2888,7 @@
     _private->customDeviceScaleFactor = customScaleFactor;
 
     if (oldScaleFactor != [self _deviceScaleFactor])
-        _private->page->setDeviceScaleFactor(customScaleFactor);
+        _private->page->setDeviceScaleFactor([self _deviceScaleFactor]);
 }
 
 - (NSUInteger)markAllMatchesForText:(NSString *)string caseSensitive:(BOOL)caseFlag highlight:(BOOL)highlight limit:(NSUInteger)limit
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to