Title: [113559] trunk/Tools
- Revision
- 113559
- Author
- [email protected]
- Date
- 2012-04-09 00:55:12 -0700 (Mon, 09 Apr 2012)
Log Message
Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329
Unreviewed. Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
line 62, in _create_unit_test_results
return UnitTestResults.results_from_string(results_xml)
NameError: global name 'UnitTestResults' is not defined
* Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_create_unit_test_results):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (113558 => 113559)
--- trunk/Tools/ChangeLog 2012-04-09 07:50:42 UTC (rev 113558)
+++ trunk/Tools/ChangeLog 2012-04-09 07:55:12 UTC (rev 113559)
@@ -1,3 +1,18 @@
+2012-04-09 Eric Seidel <[email protected]>
+
+ Enable webkit_unit_tests for commit queue and EWS while tracking failures
+ https://bugs.webkit.org/show_bug.cgi?id=83329
+
+ Unreviewed. Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
+
+ line 62, in _create_unit_test_results
+ return UnitTestResults.results_from_string(results_xml)
+ NameError: global name 'UnitTestResults' is not defined
+
+ * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
+ * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
+ (LayoutTestResultsReaderTest.test_create_unit_test_results):
+
2012-04-08 Adam Barth <[email protected]>
The port object is missing unit_tests_results_path
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py (113558 => 113559)
--- trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py 2012-04-09 07:50:42 UTC (rev 113558)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py 2012-04-09 07:55:12 UTC (rev 113559)
@@ -27,6 +27,7 @@
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
from webkitpy.common.net.layouttestresults import LayoutTestResults
+from webkitpy.common.net.unittestresults import UnitTestResults
from webkitpy.common.system.deprecated_logging import error, log
from webkitpy.tool.steps.runtests import RunTests
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py (113558 => 113559)
--- trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py 2012-04-09 07:50:42 UTC (rev 113558)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py 2012-04-09 07:55:12 UTC (rev 113559)
@@ -49,6 +49,21 @@
# layout_test_results shouldn't raise even if the results.html file is missing.
self.assertEquals(reader.results(), None)
+ def test_create_unit_test_results(self):
+ tool = MockTool()
+ reader = LayoutTestResultsReader(tool, "/var/logs")
+ unit_tests_results_path = '/mock-results/webkit_unit_tests_output.xml'
+ no_failures_xml = """<?xml version="1.0" encoding="UTF-8"?>
+<testsuites tests="3" failures="0" disabled="0" errors="0" time="11.35" name="AllTests">
+ <testsuite name="RenderTableCellDeathTest" tests="3" failures="0" disabled="0" errors="0" time="0.677">
+ <testcase name="CanSetColumn" status="run" time="0.168" classname="RenderTableCellDeathTest" />
+ <testcase name="CrashIfSettingUnsetColumnIndex" status="run" time="0.129" classname="RenderTableCellDeathTest" />
+ <testcase name="CrashIfSettingUnsetRowIndex" status="run" time="0.123" classname="RenderTableCellDeathTest" />
+ </testsuite>
+</testsuites>"""
+ tool.filesystem = MockFileSystem({unit_tests_results_path: no_failures_xml})
+ self.assertEquals(reader._create_unit_test_results(), [])
+
def test_missing_unit_test_results_path(self):
tool = MockTool()
tool.port().unit_tests_results_path = lambda: None
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
